Add PubSub action to DLP Job Trigger

[soumya92]

Adds support for an additional type of action, "Publish to PubSub", to the Data Loss Prevention Job Trigger schema.

This allows terraform users to configure their DLP triggers to publish to a PubSub topic upon completion.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests. both of those failed with make: *** No rule to make target 'test' (or 'lint'). Stop.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know). I could not find the section "tests" in the linked document.
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dlp: added pubsub action to `google_data_loss_prevention_job_trigger`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 118 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 118 insertions(+), 3 deletions(-))
TF Validator: Diff ( 3 files changed, 33 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2210
Passed tests 1967
Skipped tests: 239
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccDataLossPreventionJobTrigger_dlpJobTriggerUpdateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccBigQueryDataTable_bigtable

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccBigQueryDataTable_bigtable[Debug log]

Tests failed during RECORDING mode:
TestAccDataLossPreventionJobTrigger_dlpJobTriggerUpdateExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 133 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 133 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 33 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2211
Passed tests 1972
Skipped tests: 239
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

[c2thorn]

Looks like our linter is complaining about mmv1/third_party/terraform/tests/resource_data_loss_prevention_job_trigger_test.go

Can you try running make fmt on the file and reuploading?

[soumya92]

make fmt doesn't work (make: *** No rule to make target 'fmt'. Stop.), but I did manually go fmt that file.

None of the make commands have been working for me; do they work for you? I'm wondering if somehow my make setup is weird.

[c2thorn]

make fmt doesn't work (make: *** No rule to make target 'fmt'. Stop.), but I did manually go fmt that file.

None of the make commands have been working for me; do they work for you? I'm wondering if somehow my make setup is weird.

glad go fmt works. thinking through it, make fmt is probably only appropriate for the generated code in the provider repository (and then copying the results back to mmv1). Running make fmt in the MMv1 repository isn't useful given the repository structure

[soumya92]

Ahh that's what I was missing. I should be running the make commands in the output repo, not the magic modules repo. Thanks!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 133 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 133 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 33 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2211
Passed tests 1972
Skipped tests: 239
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 135 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 135 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 33 insertions(+), 3 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 135 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 135 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 33 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2214
Passed tests 1974
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test