New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supported values of APISERVER, CONTROLLER_MANAGER, and SCHEDULER to logging_config #6772
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @megan07, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 8 insertions(+), 8 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withLoggingConfig|TestAccComputeForwardingRule_update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick change, otherwise looks good, thanks!
@@ -523,8 +523,8 @@ as "Intel Haswell" or "Intel Sandy Bridge". | |||
|
|||
<a name="nested_logging_config"></a>The `logging_config` block supports: | |||
|
|||
* `enable_components` - (Required) The GKE components exposing logs. Supported values include: | |||
`SYSTEM_COMPONENTS` and `WORKLOADS`. | |||
* `enable_components` - (Optional) The GKE components exposing logs. Supported values include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to still be required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, changed it to "required"
…to logging_config
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 7 insertions(+), 7 deletions(-)) |
Tests analyticsTotal tests: All tests passed in REPLAYING mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…to logging_config (GoogleCloudPlatform#6772) * Add supported values of APISERVER, CONTROLLER_MANAGER, and SCHEDULER to logging_config * Add supported values of APISERVER, CONTROLLER_MANAGER, and SCHEDULER to logging_config
Add supported values of APISERVER, CONTROLLER_MANAGER, and SCHEDULER to logging_config. These values are supported after the GA of the feature of exporting GKE control plane log to customers.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.