Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for network_firewall_policy_rule and region_network_firewall_policy_rule #6799

Merged
merged 10 commits into from Nov 14, 2022

Conversation

ghabian
Copy link
Contributor

@ghabian ghabian commented Nov 8, 2022

This PR adds support for the network_firewall_policy_rule resource, and its regional counterpart (region_network_firewall_policy_rule). These resources have been integrated into the DCL already and requires DCL v1.26 .

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_network_firewall_policy_rule`
`google_compute_region_network_firewall_policy_rule`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 2297 insertions(+), 31 deletions(-))
Terraform Beta: Diff ( 7 files changed, 2299 insertions(+), 33 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2232
Passed tests 1988
Skipped tests: 241
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccComputeForwardingRule_update

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten[Debug log]
TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 2297 insertions(+), 31 deletions(-))
Terraform Beta: Diff ( 7 files changed, 2299 insertions(+), 33 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2237
Passed tests 1996
Skipped tests: 241
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a pass, comments inline!

@ghabian ghabian marked this pull request as draft November 11, 2022 01:38
@ghabian
Copy link
Contributor Author

ghabian commented Nov 11, 2022

setting to draft while changes are committed to DCL

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 2266 insertions(+))
Terraform Beta: Diff ( 7 files changed, 2266 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2244
Passed tests 2002
Skipped tests: 241
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

@ghabian
Copy link
Contributor Author

ghabian commented Nov 12, 2022

I tested in PR #6819 downstream changes from DCL 1.26.4 and there doesn't seem to be any. So I figured I'd add it in here. Let me know if I should keep the upgrade to 1.26.4 in a separate PR.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 2293 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 9 files changed, 2293 insertions(+), 5 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2250
Passed tests 2005
Skipped tests: 241
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccComputeForwardingRule_update|TestAccComputeGlobalForwardingRule_labels

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten[Debug log]
TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccComputeGlobalForwardingRule_labels[Debug log]

All tests passed
View the build log or the debug log for each test

@ghabian ghabian marked this pull request as ready for review November 12, 2022 05:16
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- there are no changes from DCL out of the ones made for change, so doing the upgrade in this PR is 👍

@rileykarson rileykarson merged commit b3f42d7 into GoogleCloudPlatform:main Nov 14, 2022
@ghabian ghabian deleted the nfp-rules branch November 14, 2022 19:26
@ghabian ghabian mentioned this pull request Nov 14, 2022
5 tasks
googlerjk pushed a commit to googlerjk/magic-modules that referenced this pull request Nov 22, 2022
…all_policy_rule (GoogleCloudPlatform#6799)

Co-authored-by: Ghaleb Al-habian <galhabian@google.com>
googlerjk pushed a commit to googlerjk/magic-modules that referenced this pull request Nov 25, 2022
…all_policy_rule (GoogleCloudPlatform#6799)

Co-authored-by: Ghaleb Al-habian <galhabian@google.com>
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Dec 6, 2022
…all_policy_rule (GoogleCloudPlatform#6799)

Co-authored-by: Ghaleb Al-habian <galhabian@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants