New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suppress diff on website #6827
suppress diff on website #6827
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 13 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeForwardingRule_update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help me understand the API behavior here? The original issue was about removing the entire website
block, which it seems like you cannot do? Should this entire field just be marked as ForceNew
?
It is true the website can't be removed at this moment. But marking it ForceNew, it will cause the bucket to be recreated even when the website is added later on, and the existing data will be lost. Do you think users will like it (vs. website can't be removed)? I don't see any negative consequences by leaving website in the bucket config even it is not used. I admit this might be a little bit off from the api's behavior. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 1 insertion(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeForwardingRule_update |
f86ef0d
to
7430ac2
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 13 insertions(+)) |
Tests analyticsTotal tests: All tests passed in REPLAYING mode |
That's a fair point. I think the true best way would be to trigger recreation only when the user attempts to remove the fields, but that is a breaking change anyway. With a diff suppress we are ignoring a true diff. At this time, it should be enough as a workaround. @edwardmedia can we at least get a test showing that this scenario doesn't produce the permadiff anymore? |
7430ac2
to
696cf61
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 57 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccStorageBucket_website |
mmv1/third_party/terraform/resources/resource_storage_bucket.go.erb
Outdated
Show resolved
Hide resolved
696cf61
to
d291bf6
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 51 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease |
Co-authored-by: Edward Sun <sunedward@google.com> Fixes hashicorp/terraform-provider-google#12870
Co-authored-by: Edward Sun <sunedward@google.com> Fixes hashicorp/terraform-provider-google#12870
Co-authored-by: Edward Sun <sunedward@google.com> Fixes hashicorp/terraform-provider-google#12870
Co-authored-by: Edward Sun <sunedward@google.com> Fixes hashicorp/terraform-provider-google#12870
Fixes hashicorp/terraform-provider-google#12870
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)