Cloudrun v2 service #6850

shuyama1 · 2022-11-18T22:00:31Z

Internal ticket: b/254103525
API: https://cloud.google.com/run/docs/reference/rest/v2/projects.locations.services

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_cloud_run_v2_service`

modular-magician · 2022-11-18T22:18:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 4611 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 4611 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 1252 insertions(+), 3 deletions(-))

modular-magician · 2022-11-18T23:12:14Z

Tests analytics

Total tests: 2279
Passed tests 2023
Skipped tests: 244
Failed tests: 12

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample|TestAccCloudRunV2Service_cloudrunv2ServiceBasicExample

modular-magician · 2022-11-18T23:37:31Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceBasicExample[Debug log]

All tests passed
View the build log or the debug log for each test

modular-magician · 2022-11-21T19:36:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 5155 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 5155 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 1247 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 16 files changed, 556 insertions(+))

shuyama1 · 2022-11-21T20:22:02Z

mmv1/products/cloudrunv2/api.yaml

+        description: |-
+          Map of string keys and values that can be used to organize and categorize objects. User-provided labels are shared with Google's billing system, so they can be used to filter, or break down billing charges by team, component, environment, state, etc. For more information, visit https://cloud.google.com/resource-manager/docs/creating-managing-labels or https://cloud.google.com/run/docs/configuring/labels Cloud Run will populate some labels with 'run.googleapis.com' or 'serving.knative.dev' namespaces. Those labels are read-only, and user changes will not be preserved.
+      # Block on b/244872932 for implementation    
+      # - !ruby/object:Api::Type::KeyValuePairs


annotation is currently blocked on b/244872932. Discussed with the service team and decide to omit the field from implementation until the API validation is launched.

shuyama1 · 2022-11-21T20:23:41Z

mmv1/products/cloudrunv2/api.yaml

+                        name: "value"
+                        description: |-
+                          Variable references $(VAR_NAME) are expanded using the previous defined environment variables in the container and any route environment variables. If a variable cannot be resolved, the reference in the input string will be unchanged. The $(VAR_NAME) syntax can be escaped with a double $$, ie: $$(VAR_NAME). Escaped references will never be expanded, regardless of whether the variable exists or not. Defaults to "", and the maximum length is 32768 bytes
+                        # exactly_one_of:


ConflictsWith, ExactlyOneOf and AtLeastOneOf within lists are currently not supported at the SDK level.

modular-magician · 2022-11-21T20:28:04Z

Tests analytics

Total tests: 2283
Passed tests 2033
Skipped tests: 244
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccCloudRunV2Service_cloudrunv2ServiceProbesUpdate|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccCloudRunV2Service_cloudrunv2ServiceProbesExample|TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample|TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample

modular-magician · 2022-11-21T20:51:51Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceProbesUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceProbesExample[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample[Debug log]

All tests passed
View the build log or the debug log for each test

roaks3

Overall this looks great to me. I noticed some small things that might need changes, but the only thing that seems like a potential blocker is a field called status which I think needs to be state.

mmv1/products/cloudrunv2/api.yaml

mmv1/products/cloudrunv2/terraform.yaml

mmv1/templates/terraform/examples/cloudrunv2_service_probes.tf.erb

modular-magician · 2022-11-22T20:19:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 5155 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 5155 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 1247 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 16 files changed, 556 insertions(+))

modular-magician · 2022-11-22T21:12:38Z

Tests analytics

Total tests: 2286
Passed tests 2040
Skipped tests: 244
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccContainerNodePool_withNodeConfig|TestAccLoggingBucketConfigProject_cmekSettings

roaks3

Adding Stephen for follow-up review

modular-magician · 2022-11-22T21:28:47Z

Tests passed during RECORDING mode:
TestAccContainerNodePool_withNodeConfig[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

melinath

a couple small changes, lgtm otherwise.

mmv1/products/cloudrunv2/api.yaml

modular-magician · 2022-11-28T23:29:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 5142 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 5142 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 1247 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 16 files changed, 556 insertions(+))

modular-magician · 2022-11-29T00:16:24Z

Tests analytics

Total tests: 2300
Passed tests 2054
Skipped tests: 244
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccLoggingBucketConfigProject_cmekSettings

modular-magician · 2022-11-29T00:23:34Z

Tests passed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

melinath

LGTM - it could be nice to have tests for container.command and liveness_probe.tcp_socket for this resource as well.

modular-magician · 2022-12-02T00:30:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 5256 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 5256 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 1242 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 20 files changed, 706 insertions(+))

modular-magician · 2022-12-02T01:14:10Z

Tests analytics

Total tests: 2318
Passed tests 2069
Skipped tests: 244
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccCloudRunV2Service_cloudrunv2ServiceSecretExample|TestAccCloudRunV2Service_cloudrunv2ServiceProbesUpdate|TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample

modular-magician · 2022-12-02T01:30:44Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceProbesUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample[Debug log]

Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceSecretExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-12-02T07:03:23Z

Tests analytics

Total tests: 2318
Passed tests 2072
Skipped tests: 244
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccLoggingBucketConfigProject_cmekSettings

modular-magician · 2022-12-02T07:04:32Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

shuyama1 · 2022-12-02T11:15:49Z

/gcbrun

modular-magician · 2022-12-02T11:32:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 5260 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 5260 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 1242 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 20 files changed, 708 insertions(+))

modular-magician · 2022-12-02T12:22:43Z

Tests analytics

Total tests: 2318
Passed tests 2072
Skipped tests: 244
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccLoggingBucketConfigProject_cmekSettings

modular-magician · 2022-12-02T12:23:49Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

shuyama1 · 2022-12-02T16:12:07Z

@melinath I suspect the TFV tests failed here maybe due to the TFV build failure for the last two commits.

melinath

+1 TFV failure is unrelated - opened #6904 to remove that test case for now.

shuyama1 · 2022-12-02T19:27:20Z

Only rebase to get TFV fix in. No new code changes and will merge it after tests pass.

modular-magician · 2022-12-02T19:41:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 5260 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 5260 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 1242 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 20 files changed, 708 insertions(+))

modular-magician · 2022-12-02T20:20:12Z

Tests analytics

Total tests: 2318
Passed tests 2072
Skipped tests: 244
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-12-02T20:21:23Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

shuyama1 force-pushed the cloud_run_2_service branch from 554536c to 033bb05 Compare November 21, 2022 19:21

shuyama1 commented Nov 21, 2022

View reviewed changes

shuyama1 marked this pull request as ready for review November 21, 2022 20:24

shuyama1 requested a review from roaks3 November 21, 2022 20:24

roaks3 requested changes Nov 22, 2022

View reviewed changes

shuyama1 force-pushed the cloud_run_2_service branch from 033bb05 to 10c7524 Compare November 22, 2022 20:02

shuyama1 requested a review from roaks3 November 22, 2022 21:13

roaks3 approved these changes Nov 22, 2022

View reviewed changes

roaks3 requested a review from melinath November 22, 2022 21:28

melinath requested changes Nov 28, 2022

View reviewed changes

shuyama1 force-pushed the cloud_run_2_service branch from 10c7524 to 7a6edb9 Compare November 28, 2022 23:14

melinath approved these changes Nov 30, 2022

View reviewed changes

shuyama1 force-pushed the cloud_run_2_service branch from 7a6edb9 to 7b932d1 Compare December 2, 2022 00:15

shuyama1 force-pushed the cloud_run_2_service branch from 7b932d1 to 587fba5 Compare December 2, 2022 01:42

melinath approved these changes Dec 2, 2022

View reviewed changes

shuyama1 added 7 commits December 2, 2022 11:24

add cloudrun v2 service

36b8440

add update feature + tests

ba19dc3

addressed comments

0765c08

addressed comment

21bda27

added secret test

9fa945a

added more tests

c69fbc6

set explicit order

5ebdbce

shuyama1 force-pushed the cloud_run_2_service branch from 587fba5 to 5ebdbce Compare December 2, 2022 19:25

shuyama1 merged commit 352a1bd into GoogleCloudPlatform:main Dec 2, 2022

shuyama1 deleted the cloud_run_2_service branch December 2, 2022 20:33

kimihrr pushed a commit to kimihrr/kimiah-magic-modules that referenced this pull request Dec 6, 2022

Cloudrun v2 service (GoogleCloudPlatform#6850)

f89dbef

hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Dec 6, 2022

Cloudrun v2 service (GoogleCloudPlatform#6850)

f167928

mmizutani mentioned this pull request Dec 18, 2022

Adds grpc field to liveness_probe and startup_probe to google_cloud_run_v2_service resource #6987

Merged

5 tasks

yanweiguo mentioned this pull request Jan 25, 2023

Adds GRPC probe support to google_cloud_run_v2_service resource #7172

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cloudrun v2 service #6850

Cloudrun v2 service #6850

shuyama1 commented Nov 18, 2022 •

edited

modular-magician commented Nov 18, 2022

modular-magician commented Nov 18, 2022

modular-magician commented Nov 18, 2022

modular-magician commented Nov 21, 2022

shuyama1 Nov 21, 2022

shuyama1 Nov 21, 2022 •

edited

modular-magician commented Nov 21, 2022

modular-magician commented Nov 21, 2022

roaks3 left a comment

modular-magician commented Nov 22, 2022

modular-magician commented Nov 22, 2022

roaks3 left a comment

modular-magician commented Nov 22, 2022

melinath left a comment

modular-magician commented Nov 28, 2022

modular-magician commented Nov 29, 2022

modular-magician commented Nov 29, 2022

melinath left a comment

modular-magician commented Dec 2, 2022

modular-magician commented Dec 2, 2022

modular-magician commented Dec 2, 2022

modular-magician commented Dec 2, 2022

modular-magician commented Dec 2, 2022

shuyama1 commented Dec 2, 2022

modular-magician commented Dec 2, 2022

modular-magician commented Dec 2, 2022

modular-magician commented Dec 2, 2022

shuyama1 commented Dec 2, 2022

melinath left a comment

shuyama1 commented Dec 2, 2022

modular-magician commented Dec 2, 2022

modular-magician commented Dec 2, 2022

modular-magician commented Dec 2, 2022

Cloudrun v2 service #6850

Cloudrun v2 service #6850

Conversation

shuyama1 commented Nov 18, 2022 • edited

modular-magician commented Nov 18, 2022

Diff report

modular-magician commented Nov 18, 2022

Tests analytics

Action taken

modular-magician commented Nov 18, 2022

modular-magician commented Nov 21, 2022

Diff report

shuyama1 Nov 21, 2022

Choose a reason for hiding this comment

shuyama1 Nov 21, 2022 • edited

Choose a reason for hiding this comment

modular-magician commented Nov 21, 2022

Tests analytics

Action taken

modular-magician commented Nov 21, 2022

roaks3 left a comment

Choose a reason for hiding this comment

modular-magician commented Nov 22, 2022

Diff report

modular-magician commented Nov 22, 2022

Tests analytics

Action taken

roaks3 left a comment

Choose a reason for hiding this comment

modular-magician commented Nov 22, 2022

melinath left a comment

Choose a reason for hiding this comment

modular-magician commented Nov 28, 2022

Diff report

modular-magician commented Nov 29, 2022

Tests analytics

Action taken

modular-magician commented Nov 29, 2022

melinath left a comment

Choose a reason for hiding this comment

modular-magician commented Dec 2, 2022

Diff report

modular-magician commented Dec 2, 2022

Tests analytics

Action taken

modular-magician commented Dec 2, 2022

modular-magician commented Dec 2, 2022

Tests analytics

Action taken

modular-magician commented Dec 2, 2022

shuyama1 commented Dec 2, 2022

modular-magician commented Dec 2, 2022

Diff report

modular-magician commented Dec 2, 2022

Tests analytics

Action taken

modular-magician commented Dec 2, 2022

shuyama1 commented Dec 2, 2022

melinath left a comment

Choose a reason for hiding this comment

shuyama1 commented Dec 2, 2022

modular-magician commented Dec 2, 2022

Diff report

modular-magician commented Dec 2, 2022

Tests analytics

Action taken

modular-magician commented Dec 2, 2022

shuyama1 commented Nov 18, 2022 •

edited

shuyama1 Nov 21, 2022 •

edited