Cloudrun v2 job #6852

shuyama1 · 2022-11-19T00:02:34Z

This should resolve hashicorp/terraform-provider-google#11743
Internal ticket: b/240175294
API doc can be found in the internal ticket

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_cloud_run_v2_job`

modular-magician · 2022-11-19T00:18:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 4321 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 4321 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 1176 insertions(+), 3 deletions(-))

modular-magician · 2022-11-19T01:06:40Z

Tests analytics

Total tests: 2279
Passed tests 2024
Skipped tests: 244
Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccCloudRunV2Job_cloudrunv2JobSqlExample|TestAccCloudRunV2Job_cloudrunv2JobBasicExample|TestAccLoggingBucketConfigProject_cmekSettings

modular-magician · 2022-11-19T01:31:01Z

Tests passed during RECORDING mode:
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobSqlExample[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobBasicExample[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

Tests failed during RECORDING mode:
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

mmv1/templates/terraform/examples/cloudrunv2_job_sql.tf.erb

modular-magician · 2022-11-22T19:35:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 4822 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 4822 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 1150 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 16 files changed, 553 insertions(+))

modular-magician · 2022-11-22T20:15:50Z

Tests analytics

Total tests: 2285
Passed tests 2034
Skipped tests: 244
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerNodePool_withNodeConfig|TestAccCloudRunV2Job_cloudrunv2JobFullUpdate|TestAccCloudRunV2Job_cloudrunv2JobProbesExample|TestAccCloudRunV2Job_cloudrunv2JobProbesUpdate|TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample

modular-magician · 2022-11-22T20:31:59Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerNodePool_withNodeConfig[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobProbesExample[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobProbesUpdate[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample[Debug log]

Tests failed during RECORDING mode:
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-11-22T21:08:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 4820 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 4820 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 1150 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 16 files changed, 553 insertions(+))

modular-magician · 2022-11-22T21:57:23Z

Tests analytics

Total tests: 2286
Passed tests 2039
Skipped tests: 244
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccCloudRunV2Job_cloudrunv2JobFullUpdate|TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-11-22T22:04:22Z

Tests passed during RECORDING mode:
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

bogaertg · 2022-11-29T08:51:45Z

up ?

modular-magician · 2022-11-29T16:54:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 4962 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 4962 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 1150 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 20 files changed, 705 insertions(+))

modular-magician · 2022-11-29T17:45:47Z

Tests analytics

Total tests: 2309
Passed tests 2053
Skipped tests: 244
Failed tests: 12

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccDataFusionInstance_dataFusionInstanceZoneExample|TestAccDataFusionInstance_dataFusionInstanceEventExample|TestAccDataFusionInstance_dataFusionInstanceFullExample|TestAccCloudRunV2Job_cloudrunv2JobSecretExample|TestAccDataFusionInstanceIamPolicyGenerated|TestAccDataFusionInstanceIamMemberGenerated|TestAccDataFusionInstanceIamBindingGenerated|TestAccVertexAIIndex_updated|TestAccVertexAIIndex_vertexAiIndexStreamingExample|TestAccVertexAIIndex_vertexAiIndexExample|TestAccLoggingBucketConfigProject_cmekSettings

modular-magician · 2022-11-29T18:45:23Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDataFusionInstance_dataFusionInstanceZoneExample[Debug log]
TestAccDataFusionInstance_dataFusionInstanceEventExample[Debug log]
TestAccDataFusionInstance_dataFusionInstanceFullExample[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobSecretExample[Debug log]
TestAccDataFusionInstanceIamPolicyGenerated[Debug log]
TestAccDataFusionInstanceIamMemberGenerated[Debug log]
TestAccDataFusionInstanceIamBindingGenerated[Debug log]
TestAccVertexAIIndex_updated[Debug log]
TestAccVertexAIIndex_vertexAiIndexStreamingExample[Debug log]
TestAccVertexAIIndex_vertexAiIndexExample[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

roaks3

Looks great! A vast majority of this matches the cloudrun service, and from what I saw, everything looked consistent.

Only nit is that I didn't see some fields in the update test (for example, container.command and livenessProbe.tcpSocket), but I don't know if we generally aim for full coverage there.

Adding Stephen for follow-up

melinath

LGTM - one question below.

Adding tests for the fields Ryan mentioned above does seem like it would be nice to do.

melinath · 2022-11-30T17:21:28Z

mmv1/products/cloudrunv2/api.yaml

+                            name: "value"
+                            description: |-
+                              Variable references $(VAR_NAME) are expanded using the previous defined environment variables in the container and any route environment variables. If a variable cannot be resolved, the reference in the input string will be unchanged. The $(VAR_NAME) syntax can be escaped with a double $$, ie: $$(VAR_NAME). Escaped references will never be expanded, regardless of whether the variable exists or not. Defaults to "", and the maximum length is 32768 bytes
+                            # exactly_one_of:


Copying from the cloud run service PR:

ConflictsWith, ExactlyOneOf and AtLeastOneOf within lists are currently not supported at the SDK level.

mmv1/products/cloudrunv2/api.yaml

shuyama1 · 2022-11-30T17:53:41Z

Thanks @roaks3 and @melinath! I'll add more test coverage.

modular-magician · 2022-11-30T21:42:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 5025 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 5025 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 1150 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 20 files changed, 705 insertions(+))

modular-magician · 2022-11-30T22:24:16Z

Tests analytics

Total tests: 2309
Passed tests 2058
Skipped tests: 244
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudRunV2Job_cloudrunv2JobFullUpdate|TestAccCloudRunV2Job_cloudrunv2JobProbesUpdate

modular-magician · 2022-11-30T22:30:24Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobProbesUpdate[Debug log]

Tests failed during RECORDING mode:
TestAccCloudFunctions2Function_fullUpdate[Error message] [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[Error message] [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1 · 2022-11-30T23:35:21Z

cl/492014758 which disallows job.name in v2 CreateJobRequest is submitted and will be rolled out next week. Therefore, I marked the name field url_param_only. (name is long form output only in API but in Terraform we implement it as short-form name)

modular-magician · 2022-11-30T23:51:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 5001 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 5001 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 1140 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 20 files changed, 705 insertions(+))

modular-magician · 2022-12-01T00:30:34Z

Tests analytics

Total tests: 2309
Passed tests 2056
Skipped tests: 244
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccCloudRunV2Job_cloudrunv2JobBasicExample|TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample|TestAccCloudRunV2Job_cloudrunv2JobSqlExample|TestAccCloudRunV2Job_cloudrunv2JobProbesUpdate|TestAccCloudRunV2Job_cloudrunv2JobFullUpdate|TestAccCloudRunV2Job_cloudrunv2JobSecretExample|TestAccCloudRunV2Job_cloudrunv2JobProbesExample|TestAccLoggingBucketConfigProject_cmekSettings

modular-magician · 2022-12-01T00:47:05Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobBasicExample[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobSqlExample[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobProbesUpdate[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobSecretExample[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobProbesExample[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

resolve hashicorp/terraform-provider-google#11743

jeremad reviewed Nov 22, 2022

View reviewed changes

mmv1/templates/terraform/examples/cloudrunv2_job_sql.tf.erb Show resolved Hide resolved

shuyama1 force-pushed the cloud_run_2_job branch from c5ae89b to cab0a18 Compare November 22, 2022 19:14

shuyama1 marked this pull request as ready for review November 22, 2022 19:22

shuyama1 requested a review from roaks3 November 22, 2022 21:17

shuyama1 added 4 commits November 28, 2022 15:37

add cloud run v2 job

0711d12

implement update feature and tests

82bac98

clean up

4c2a8ed

remove cpu_idle from tests

30cd2b2

address some comments + add secret example

77f8870

shuyama1 force-pushed the cloud_run_2_job branch from a9012ab to 77f8870 Compare November 29, 2022 16:38

roaks3 mentioned this pull request Nov 29, 2022

WIP: Add cloud_run_job resource #6552

Closed

5 tasks

roaks3 approved these changes Nov 29, 2022

View reviewed changes

roaks3 requested a review from melinath November 29, 2022 21:14

melinath approved these changes Nov 30, 2022

View reviewed changes

add more tests + make version required

fceb56e

melinath approved these changes Nov 30, 2022

View reviewed changes

mark name as url_only and remove cpuIdle

9b85aa5

melinath approved these changes Dec 1, 2022

View reviewed changes

shuyama1 merged commit a5a8691 into GoogleCloudPlatform:main Dec 1, 2022

5fff pushed a commit to 5fff/magic-modules that referenced this pull request Dec 5, 2022

Cloudrun v2 job (GoogleCloudPlatform#6852)

421a144

resolve hashicorp/terraform-provider-google#11743

kimihrr pushed a commit to kimihrr/kimiah-magic-modules that referenced this pull request Dec 6, 2022

Cloudrun v2 job (GoogleCloudPlatform#6852)

a401d81

resolve hashicorp/terraform-provider-google#11743

hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Dec 6, 2022

Cloudrun v2 job (GoogleCloudPlatform#6852)

58637e9

resolve hashicorp/terraform-provider-google#11743

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cloudrun v2 job #6852

Cloudrun v2 job #6852

shuyama1 commented Nov 19, 2022 •

edited

modular-magician commented Nov 19, 2022

modular-magician commented Nov 19, 2022

modular-magician commented Nov 19, 2022

modular-magician commented Nov 22, 2022

modular-magician commented Nov 22, 2022

modular-magician commented Nov 22, 2022

modular-magician commented Nov 22, 2022

modular-magician commented Nov 22, 2022

modular-magician commented Nov 22, 2022

bogaertg commented Nov 29, 2022

modular-magician commented Nov 29, 2022

modular-magician commented Nov 29, 2022

modular-magician commented Nov 29, 2022

roaks3 left a comment

melinath left a comment

melinath Nov 30, 2022

shuyama1 commented Nov 30, 2022

modular-magician commented Nov 30, 2022

modular-magician commented Nov 30, 2022

modular-magician commented Nov 30, 2022

shuyama1 commented Nov 30, 2022 •

edited

modular-magician commented Nov 30, 2022

modular-magician commented Dec 1, 2022

modular-magician commented Dec 1, 2022

Cloudrun v2 job #6852

Cloudrun v2 job #6852

Conversation

shuyama1 commented Nov 19, 2022 • edited

modular-magician commented Nov 19, 2022

Diff report

modular-magician commented Nov 19, 2022

Tests analytics

Action taken

modular-magician commented Nov 19, 2022

modular-magician commented Nov 22, 2022

Diff report

modular-magician commented Nov 22, 2022

Tests analytics

Action taken

modular-magician commented Nov 22, 2022

modular-magician commented Nov 22, 2022

Diff report

modular-magician commented Nov 22, 2022

Tests analytics

Action taken

modular-magician commented Nov 22, 2022

bogaertg commented Nov 29, 2022

modular-magician commented Nov 29, 2022

Diff report

modular-magician commented Nov 29, 2022

Tests analytics

Action taken

modular-magician commented Nov 29, 2022

roaks3 left a comment

Choose a reason for hiding this comment

melinath left a comment

Choose a reason for hiding this comment

melinath Nov 30, 2022

Choose a reason for hiding this comment

shuyama1 commented Nov 30, 2022

modular-magician commented Nov 30, 2022

Diff report

modular-magician commented Nov 30, 2022

Tests analytics

Action taken

modular-magician commented Nov 30, 2022

shuyama1 commented Nov 30, 2022 • edited

modular-magician commented Nov 30, 2022

Diff report

modular-magician commented Dec 1, 2022

Tests analytics

Action taken

modular-magician commented Dec 1, 2022

shuyama1 commented Nov 19, 2022 •

edited

shuyama1 commented Nov 30, 2022 •

edited