Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default for google_sql_database.deletion_policy to DELETE #6936

Merged
merged 2 commits into from Dec 12, 2022
Merged

Change the default for google_sql_database.deletion_policy to DELETE #6936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a98002b
Change the default for google_sql_database.deletion_policy to DELETE …
rileykarson Dec 9, 2022
53bf418
Fix test
rileykarson Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion mmv1/products/firebase/api.yaml
View file
Open in desktop
Expand Up @@ -190,6 +190,7 @@ objects:
path: 'error'
message: 'message'
parameters:
# TODO: make this an enum in a future major version. If using this field as a reference, look at PerInstanceConfig's minimal_action field for enum configuration.
- !ruby/object:Api::Type::String
name: 'deletion_policy'
description: |
Expand Down Expand Up @@ -257,6 +258,7 @@ objects:
path: 'error'
message: 'message'
parameters:
# TODO: make this an enum in a future major version. If using this field as a reference, look at PerInstanceConfig's minimal_action field for enum configuration.
- !ruby/object:Api::Type::String
name: 'deletion_policy'
description: |
Expand Down Expand Up @@ -295,4 +297,4 @@ objects:
- !ruby/object:Api::Type::String
name: teamId
description: |
The Apple Developer Team ID associated with the App in the App Store.
The Apple Developer Team ID associated with the App in the App Store.
1 change: 1 addition & 0 deletions mmv1/products/firebase/terraform.yaml
View file
Open in desktop
Expand Up @@ -56,6 +56,7 @@ overrides: !ruby/object:Overrides::ResourceOverrides
- project
- deletion_policy
virtual_fields:
# TODO: make this an enum in a future major version. If using this field as a reference, look at PerInstanceConfig's minimal_action field for enum configuration.
- !ruby/object:Api::Type::String
name: 'deletion_policy'
description: |
Expand Down
7 changes: 5 additions & 2 deletions mmv1/products/sql/terraform.yaml
View file
Open in desktop
Expand Up @@ -39,6 +39,8 @@ overrides: !ruby/object:Overrides::ResourceOverrides
- !ruby/object:Provider::Terraform::Examples
name: "sql_database_deletion_policy"
primary_resource_id: "database_deletion_policy"
ignore_read_extra:
- "deletion_policy"
vars:
database_name: "my-database"
database_instance_name: "my-database-instance"
Expand All @@ -54,14 +56,15 @@ overrides: !ruby/object:Overrides::ResourceOverrides
default_from_api: true
diff_suppress_func: 'caseDiffSuppress'
virtual_fields:
# TODO: make this an enum in a future major version. If using this field as a reference, look at PerInstanceConfig's minimal_action field for enum configuration.
- !ruby/object:Api::Type::String
name: 'deletion_policy'
description: |
The deletion policy for the database. Setting ABANDON allows the resource
to be abandoned rather than deleted. This is useful for Postgres, where databases cannot be
deleted from the API if there are users other than cloudsqlsuperuser with access. Possible
values are: "ABANDON".
default_value: "ABANDON"
values are: "ABANDON", "DELETE". Defaults to "DELETE".
default_value: "DELETE"
custom_code: !ruby/object:Provider::Terraform::CustomCode
pre_delete: templates/terraform/pre_delete/sql_database_deletion_policy.erb
SourceRepresentationInstance: !ruby/object:Overrides::Terraform::ResourceOverride
Expand Down