Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding serviceDirectoryRegion to Forwarding rule #7480

Closed

Conversation

davelanglois-ssc
Copy link

@davelanglois-ssc davelanglois-ssc commented Mar 16, 2023

adding serviceDirectoryRegistrations[].serviceDirectoryRegion support to resource_compute_forwarding_rule.go as per rest api

fixes hashicorp/terraform-provider-google#9758

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `serviceDirectoryRegistrations[].serviceDirectoryRegion ` field to `forwardingRules` resource

adding serviceDirectoryRegistrations[].serviceDirectoryRegion support to resource_compute_forwarding_rule.go
as per rest [api](https://cloud.google.com/compute/docs/reference/rest/v1/forwardingRules/insert#request-body)
@davelanglois-ssc davelanglois-ssc requested a review from a team as a code owner March 16, 2023 21:34
@davelanglois-ssc davelanglois-ssc requested review from shuyama1 and removed request for a team March 16, 2023 21:34
@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@shuyama1
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 6 insertions(+))
Terraform Beta: Diff ( 1 file changed, 6 insertions(+))
TF Validator: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))

@shuyama1
Copy link
Member

@davelanglois-ssc Sorry, looks like google_compute_forwarding_rule is a DCL based resource https://github.com/hashicorp/terraform-provider-google-beta/blob/main/google-beta/resource_compute_forwarding_rule.go#L3 that its feature is implemented internally. Would you mind filing a ticket for this feature via https://github.com/hashicorp/terraform-provider-google/issues/new?assignees=&labels=enhancement&template=01_enhancement.md

@davelanglois-ssc
Copy link
Author

issue #hashicorp/terraform-provider-google#14049 opened. let me know if it's description is not including enough information

@shuyama1
Copy link
Member

@davelanglois-ssc Thanks for creating the issue. Closing this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants