-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding serviceDirectoryRegion to Forwarding rule #7480
adding serviceDirectoryRegion to Forwarding rule #7480
Conversation
adding serviceDirectoryRegistrations[].serviceDirectoryRegion support to resource_compute_forwarding_rule.go as per rest [api](https://cloud.google.com/compute/docs/reference/rest/v1/forwardingRules/insert#request-body)
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 6 insertions(+)) |
@davelanglois-ssc Sorry, looks like |
issue #hashicorp/terraform-provider-google#14049 opened. let me know if it's description is not including enough information |
@davelanglois-ssc Thanks for creating the issue. Closing this PR then. |
adding serviceDirectoryRegistrations[].serviceDirectoryRegion support to resource_compute_forwarding_rule.go as per rest api
fixes hashicorp/terraform-provider-google#9758
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)