Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for advanced_datapath_observability_config to google_container_cluster #8372

Closed
wants to merge 1 commit into from

Conversation

epk
Copy link
Contributor

@epk epk commented Jul 18, 2023

Adds support for https://cloud.google.com/kubernetes-engine/docs/how-to/configure-dpv2-observability#configure-gke-dataplane-v2-metrics


If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: added support for `advanced_datapath_observability_config` to `google_container_cluster`

@google-cla
Copy link

google-cla bot commented Jul 18, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 18, 2023
@epk epk force-pushed the dpv2-metrics branch 4 times, most recently from 63cd5fe to ed0ca1d Compare July 18, 2023 09:42
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 18, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 112 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 5 files changed, 111 insertions(+), 32 deletions(-))
TF Conversion: Diff ( 2 files changed, 27 insertions(+), 27 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

@rileykarson
Copy link
Member

From the failing build:

==> Checking that code complies with gofmt requirements...
go vet
go: cloud.google.com/go/compute@v1.1[9](https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/5591925258/jobs/10223680551#step:9:10).3: missing go.sum entry for go.mod file; to add it:
	go mod download cloud.google.com/go/compute
make: *** [GNUmakefile:26: vet] Error 1
Error: Process completed with exit code 2.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 18, 2023
@epk epk force-pushed the dpv2-metrics branch 2 times, most recently from 96933fb to 712c5b9 Compare July 18, 2023 21:09
@epk epk changed the title Add support for advanced_datapath metrics to google_container_cluster Add support for advanced_datapath_observability_config to google_container_cluster Jul 18, 2023
@epk
Copy link
Contributor Author

epk commented Jul 19, 2023

@rileykarson should be good to test/review. Thanks!

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 19, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 172 insertions(+), 37 deletions(-))
Terraform Beta: Diff ( 5 files changed, 172 insertions(+), 37 deletions(-))
TF Conversion: Diff ( 2 files changed, 27 insertions(+), 27 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2872
Passed tests 2568
Skipped tests: 299
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig|TestAccContainerCluster_withMonitoringConfig|TestAccComputeInstance_minCpuPlatform|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_withMonitoringConfig[Debug log]
TestAccComputeInstance_minCpuPlatform[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig[Error message] [Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 21, 2023
@epk
Copy link
Contributor Author

epk commented Jul 21, 2023

Rebased on main

@epk epk closed this Jul 24, 2023
@epk epk force-pushed the dpv2-metrics branch 2 times, most recently from d6b942f to 63eca84 Compare July 24, 2023 07:25
…oogle_container_cluster

Signed-off-by: Aditya Sharma <aditya.sharma@shopify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests
Projects
None yet
3 participants