Stateful ips ga

[askubis]

This promotes Stateful IPs functionalities to GA . Modifies (Region)InstanceGroupManagers and (Region)PerInstanceConfigs.
fixes #10908

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
While running the tests one of them fails (TestAccInstanceGroupManager_waitForStatus), but it does not use the new field and it simply times out.
Read Write release notes before writing my release note below.
Release Note Template for Downstream PRs (will be copied)

compute: promoted `internal_ip` and `external_ip` fields in resources `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager` to GA

compute: promoted `internal_ip` and `external_ip` fields in resources `google_compute_per_instance_config` and `google_compute_region_per_instance_config` to GA

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[roaks3]

LGTM assuming tests pass. I've also tweaked the release note to be more consistent with our other GA promotions

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 1197 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 9 files changed, 18 insertions(+), 14 deletions(-))

[askubis]

I have added all changes I noticed to go.sum in the terraform-provider-google, PLMK if this isn't the way to do this correctly.

Regards,
Adam

[roaks3]

Ah yep, I didn't get around to sharing the build error, but it does look like a go.sum issue. I'll re-run tests to see if that fixes it.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field preserved_state.external_ip.interface_name changed from optional to required on google_compute_per_instance_config - reference
• Field preserved_state.external_ip.interface_name changed from optional to required on google_compute_region_per_instance_config - reference
• Field preserved_state.internal_ip.interface_name changed from optional to required on google_compute_per_instance_config - reference
• Field preserved_state.internal_ip.interface_name changed from optional to required on google_compute_region_per_instance_config - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 14 files changed, 1221 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 10 files changed, 42 insertions(+), 14 deletions(-))

[roaks3]

Step #22 - "gcb-tpg-vcr-test": go: updates to go.mod needed; to update it:
Step #22 - "gcb-tpg-vcr-test": 	go mod tidy

Looks like you'll need to run go mod tidy and try again with the updated go.sum

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field preserved_state.external_ip.interface_name changed from optional to required on google_compute_per_instance_config - reference
• Field preserved_state.external_ip.interface_name changed from optional to required on google_compute_region_per_instance_config - reference
• Field preserved_state.internal_ip.interface_name changed from optional to required on google_compute_per_instance_config - reference
• Field preserved_state.internal_ip.interface_name changed from optional to required on google_compute_region_per_instance_config - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 14 files changed, 1229 insertions(+), 17 deletions(-))
Terraform Beta: Diff ( 10 files changed, 50 insertions(+), 22 deletions(-))

[askubis]

I've fixed the go.sum, thanks for your help!
I think the "Breaking Change(s) Detected" notice is wrong. I don't see the changes it sais are there.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 14 files changed, 1230 insertions(+), 44 deletions(-))
Terraform Beta: Diff ( 10 files changed, 51 insertions(+), 49 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 14 files changed, 1233 insertions(+), 47 deletions(-))
Terraform Beta: Diff ( 10 files changed, 54 insertions(+), 52 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3120
Passed tests 2802
Skipped tests: 318
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[roaks3]

LGTM, thanks for working through the dependency issues