Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dcl version #9370

Merged
merged 12 commits into from
Nov 2, 2023
Merged

update dcl version #9370

merged 12 commits into from
Nov 2, 2023

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Oct 26, 2023

upgrade DCL to v1.55.0 (pending release note writing)

  • google_assured_workloads_workload partner fields caused issues in DCL tests, so I did not include samples for them
  • we have no google_gke_hub_feature_membership tests

Release Note Template for Downstream PRs (will be copied)

assuredworkloads: added `enable_sovereign_controls`, `partner`, `partner_permissions`, `violation_notifications_enabled`, and several other output-only fields to `google_assured_workloads_workloads`
containeraws: added `admin_groups` to `google_container_aws_cluster`
containerazure: added `admin_groups` to `google_container_azure_cluster`
gkehub: added `metrics_gcp_service_account_email` to `google_gke_hub_feature_membership`

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@c2thorn c2thorn requested a review from trodge October 31, 2023 17:31
Copy link
Contributor

@trodge trodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a separate PR for adding tests covering the changes?

@modular-magician

This comment was marked as outdated.

@c2thorn
Copy link
Member Author

c2thorn commented Nov 1, 2023

Is there a separate PR for adding tests covering the changes?

I've added the remaining missing tests in this PR, they should run now. The following don't have tests:

  • google_assured_workloads_workload partner fields caused issues in DCL tests, so I did not include samples for them
  • we have no google_gke_hub_feature_membership tests

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 1005 insertions(+), 114 deletions(-))
Terraform Beta: Diff ( 14 files changed, 789 insertions(+), 106 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_assured_workloads_workload (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_assured_workloads_workload" "primary" {
  partner = # value needed
  partner_permissions {
    assured_workloads_monitoring = # value needed
    data_logs_viewer             = # value needed
    service_access_approver      = # value needed
  }
}

Resource: google_gke_hub_feature_membership (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_hub_feature_membership" "primary" {
  configmanagement {
    config_sync {
      metrics_gcp_service_account_email = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3196
Passed tests 2868
Skipped tests: 325
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccDataprocClusterIamPolicy|TestAccDataprocJobIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAssuredWorkloadsWorkload_BasicHandWritten[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@c2thorn c2thorn requested a review from trodge November 1, 2023 22:02
Copy link
Contributor

@trodge trodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

There may need to be some follow-up to copy the assured workloads and gke hub tests over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants