Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for edgecontaienr update method and remove machine filter in test #9412

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

rayccz2
Copy link
Contributor

@rayccz2 rayccz2 commented Nov 6, 2023

Bug fix for edgecontaienr update method and remove machine filter in test

Release Note Template for Downstream PRs (will be copied)

Bug fix for edgecontaienr update method and remove machine filter in test

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 116 insertions(+), 58 deletions(-))
Terraform Beta: Diff ( 3 files changed, 116 insertions(+), 58 deletions(-))
TF OiCS: Diff ( 1 file changed, 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3206
Passed tests 2880
Skipped tests: 325
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccLoggingProjectSink_updatePreservesCustomWriter

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccLoggingProjectSink_updatePreservesCustomWriter[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@trodge trodge merged commit 5923d4c into GoogleCloudPlatform:main Nov 10, 2023
14 checks passed
swamitagupta pushed a commit to swamitagupta/magic-modules that referenced this pull request Nov 14, 2023
…test (GoogleCloudPlatform#9412)

* Fix edgecontainer cluster upgrade endpoint the internal test

* Bug fix for edgecontaienr update method and remove machine filter in test
trodge pushed a commit to trodge/magic-modules that referenced this pull request Nov 27, 2023
…test (GoogleCloudPlatform#9412)

* Fix edgecontainer cluster upgrade endpoint the internal test

* Bug fix for edgecontaienr update method and remove machine filter in test
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 28, 2023
…test (GoogleCloudPlatform#9412)

* Fix edgecontainer cluster upgrade endpoint the internal test

* Bug fix for edgecontaienr update method and remove machine filter in test
jialei-chen pushed a commit to jialei-chen/magic-modules that referenced this pull request Nov 29, 2023
…test (GoogleCloudPlatform#9412)

* Fix edgecontainer cluster upgrade endpoint the internal test

* Bug fix for edgecontaienr update method and remove machine filter in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants