Add access restrictions field for google_iam_workforce_pool resource

[omkark-google]

Add support for access restrictions fields to create workforce pool operation. This address the gap between newly added support in Gcloud command of iam create workforce pool.

iam: added `allowedServices`, `disableProgrammaticSignin` fields to `google_iam_workforce_pool` resource

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 221 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 4 files changed, 221 insertions(+), 23 deletions(-))
TF Conversion: Diff ( 1 file changed, 62 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_workforce_pool (19 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_workforce_pool" "primary" {
  access_restrictions {
    allowed_services {
      domain = # value needed
    }
    disable_programmatic_signin = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 3235
Passed tests 2903
Skipped tests: 330
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIAMWorkforcePoolWorkforcePool_iamWorkforcePoolFullExample|TestAccIAMWorkforcePoolWorkforcePool_full

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 219 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 5 files changed, 219 insertions(+), 28 deletions(-))
TF Conversion: Diff ( 1 file changed, 62 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_workforce_pool (19 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_workforce_pool" "primary" {
  access_restrictions {
    allowed_services {
      domain = # value needed
    }
    disable_programmatic_signin = # value needed
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 215 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 4 files changed, 215 insertions(+), 21 deletions(-))
TF Conversion: Diff ( 1 file changed, 62 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_workforce_pool (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_workforce_pool" "primary" {
  access_restrictions {
    allowed_services {
      domain = # value needed
    }
    disable_programmatic_signin = # value needed
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 215 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 4 files changed, 215 insertions(+), 21 deletions(-))
TF Conversion: Diff ( 1 file changed, 62 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3235
Passed tests 2903
Skipped tests: 330
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIAMWorkforcePoolWorkforcePool_full|TestAccIAMWorkforcePoolWorkforcePool_iamWorkforcePoolFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIAMWorkforcePoolWorkforcePool_iamWorkforcePoolFullExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIAMWorkforcePoolWorkforcePool_full[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 206 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 4 files changed, 206 insertions(+), 21 deletions(-))
TF Conversion: Diff ( 1 file changed, 62 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3236
Passed tests 2905
Skipped tests: 330
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIAMWorkforcePoolWorkforcePool_full

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIAMWorkforcePoolWorkforcePool_full[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 206 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 4 files changed, 206 insertions(+), 21 deletions(-))
TF Conversion: Diff ( 1 file changed, 62 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3236
Passed tests 2903
Skipped tests: 330
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocJobIamPolicy|TestAccIAMWorkforcePoolWorkforcePool_full|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIAMWorkforcePoolWorkforcePool_full[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 212 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 4 files changed, 212 insertions(+), 21 deletions(-))
TF Conversion: Diff ( 1 file changed, 62 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3236
Passed tests 2904
Skipped tests: 330
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIAMWorkforcePoolWorkforcePool_full|TestAccIAMWorkforcePoolWorkforcePool_minimal

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIAMWorkforcePoolWorkforcePool_full[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIAMWorkforcePoolWorkforcePool_minimal[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[ScottSuarez]

Heya ! I notice this is draft. Let me know when you would like me to make a pass :)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 227 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 4 files changed, 227 insertions(+), 23 deletions(-))
TF Conversion: Diff ( 1 file changed, 62 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3236
Passed tests 2905
Skipped tests: 330
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIAMWorkforcePoolWorkforcePool_minimal

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIAMWorkforcePoolWorkforcePool_minimal[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 227 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 4 files changed, 227 insertions(+), 22 deletions(-))
TF Conversion: Diff ( 1 file changed, 62 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3236
Passed tests 2906
Skipped tests: 330
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[omkark-google]

@ScottSuarez PR is ready for review. Can you please help to review the PR ?

[ScottSuarez]

    vcr_utils.go:152: Step 3/4 error: Error running pre-apply refresh: exit status 1
        
        Error: Unclosed configuration block
        
          on terraform_plugin_test.tf line 2, in resource "google_iam_workforce_pool" "my_pool":
           2: resource "google_iam_workforce_pool" "my_pool" {
        
        There is no closing brace for this block before the end of the file. This may
        be caused by incorrect brace nesting elsewhere in this file.
    testing_new.go:73: Error retrieving state, there may be dangling resources: exit status 1
        
        Error: Unclosed configuration block
        
          on terraform_plugin_test.tf line 2, in resource "google_iam_workforce_pool" "my_pool":
           2: resource "google_iam_workforce_pool" "my_pool" {
        
        There is no closing brace for this block before the end of the file. This may
        be caused by incorrect brace nesting elsewhere in this file.
--- FAIL: TestAccIAMWorkforcePoolWorkforcePool_minimal (88.03s)

[omkark-google]

@ScottSuarez can you please point me to test where you see the error. I believe it is fixed as part of this commit 2f05714

[ScottSuarez]

@ScottSuarez can you please point me to test where you see the error. I believe it is fixed as part of this commit 2f05714

🤦🏻 ah you're correct sorry !