Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beta min_version from the Cloud Run Service depends_on container field #9496

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

ian-mi
Copy link
Contributor

@ian-mi ian-mi commented Nov 17, 2023

Moves the Cloud Run Service container dependencies feature out of beta now that Cloud Run sidecars are GA https://cloud.google.com/run/docs/release-notes#November_13_2023.

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: promoted field `depends_on` in `google_cloud_run_v2_service` to GA

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/run and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Nov 17, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 25 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests did not run because there was no change to Beta (only GA had fields added). Diff looked good, so considering this change ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants