Add resource EventThreatDetectionCustomModule #9509

luobopi · 2023-11-21T23:33:27Z

Related to b/306108528. Add support for https://cloud.google.com/security-command-center/docs/reference/rest/v1/organizations.eventThreatDetectionSettings.customModules.

Release Note Template for Downstream PRs (will be copied)

`google_scc_event_threat_detection_custom_module`

modular-magician · 2023-11-21T23:35:08Z

Hello! I am a robot. It looks like you are a: ~~Community Contributor~~ Googler ~~Core Contributor~~. Tests will run automatically.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-11-21T23:44:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 889 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 889 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 108 insertions(+))

modular-magician · 2023-11-21T23:57:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 889 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 889 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 108 insertions(+))

modular-magician · 2023-11-22T01:09:25Z

Tests analytics

Total tests: 3238
Passed tests 2907
Skipped tests: 330
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSecurityCenterEventThreatDetectionCustomModule

Get to know how VCR tests work

modular-magician · 2023-11-22T01:10:38Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterEventThreatDetectionCustomModule[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-11-22T03:48:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 889 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 889 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 108 insertions(+))

modular-magician · 2023-11-22T05:00:08Z

Tests analytics

Total tests: 3238
Passed tests 2906
Skipped tests: 330
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccSecurityCenterEventThreatDetectionCustomModule

Get to know how VCR tests work

modular-magician · 2023-11-22T05:04:31Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]
TestAccSecurityCenterEventThreatDetectionCustomModule[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

roaks3

Had a few preliminary comments, but I also have a meta-question regarding the tests: when this resource is created against our test organizations, will that change how the organization behaves? If so, we may want to use GetTestOrgTargetFromEnv instead, which can support behavior changes (since it doesn't actually hold all of the resources we use for tests), and also have the benefit of isolating by environment (because we have 3 of them, 1 dedicated to each env).

mmv1/products/securitycenter/EventThreatDetectionCustomModule.yaml

mmv1/templates/terraform/examples/scc_event_threat_detection_custom_module.tf.erb

.../terraform/services/securitycenter/resource_scc_event_threat_detection_custom_module_test.go

modular-magician · 2023-11-28T22:57:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 889 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 889 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 108 insertions(+))

modular-magician · 2023-11-29T00:10:13Z

Tests analytics

Total tests: 3242
Passed tests 2910
Skipped tests: 331
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSecurityCenterEventThreatDetectionCustomModule

Get to know how VCR tests work

modular-magician · 2023-11-29T00:11:26Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterEventThreatDetectionCustomModule[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-11-29T18:26:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 889 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 889 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 108 insertions(+))

modular-magician · 2023-11-29T19:38:10Z

Tests analytics

Total tests: 3243
Passed tests 2910
Skipped tests: 331
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocClusterIamPolicy|TestAccSecurityCenterEventThreatDetectionCustomModule

Get to know how VCR tests work

modular-magician · 2023-11-29T19:45:37Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]
TestAccSecurityCenterEventThreatDetectionCustomModule[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

.../terraform/services/securitycenter/resource_scc_event_threat_detection_custom_module_test.go

roaks3

I think we need a few more small changes, but for the most part things look good, and we should be able to merge after the remaining feedback is addressed.

modular-magician · 2023-11-30T23:10:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 888 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 888 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 108 insertions(+))

modular-magician · 2023-12-01T00:22:45Z

Tests analytics

Total tests: 3255
Passed tests 2922
Skipped tests: 331
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEHub2Fleet_gkehubFleetBasicExample_update|TestAccSecurityCenterEventThreatDetectionCustomModule

Get to know how VCR tests work

modular-magician · 2023-12-01T00:37:11Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGKEHub2Fleet_gkehubFleetBasicExample_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccGKEHub2Fleet_gkehubFleetBasicExample_update[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterEventThreatDetectionCustomModule[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-12-01T02:33:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 879 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 879 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 108 insertions(+))

roaks3

Code LGTM, will just wait for test results to merge

modular-magician · 2023-12-01T03:45:42Z

Tests analytics

Total tests: 3255
Passed tests 2921
Skipped tests: 331
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEHub2Fleet_gkehubFleetBasicExample_update|TestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccSecurityCenterEventThreatDetectionCustomModule

Get to know how VCR tests work

modular-magician · 2023-12-01T03:58:24Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGKEHub2Fleet_gkehubFleetBasicExample_update[Debug log]
TestAccSecurityCenterEventThreatDetectionCustomModule[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccGKEHub2Fleet_gkehubFleetBasicExample_update[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLoggingProjectSink_updatePreservesCustomWriter[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

roaks3 · 2023-12-01T14:51:38Z

Note: updated release note per https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/

mmv1/products/securitycenter/EventThreatDetectionCustomModule.yaml

* Add resource EventThreatDetectionCustomModule * Fix yaml format issue * Fix TestAccSecurityCenterEventThreatDetectionCustomModule test * Address comments * Change back to use GetTestOrgFromEnv in testing * Improve test example * Change parameter type to be immutable

Add resource EventThreatDetectionCustomModule

dda0cf6

modular-magician requested a review from roaks3 November 21, 2023 23:35

modular-magician added the service/securitycenter label Nov 21, 2023

Fix yaml format issue

c657893

luobopi marked this pull request as ready for review November 21, 2023 23:57

Fix TestAccSecurityCenterEventThreatDetectionCustomModule test

e9bd307

roaks3 reviewed Nov 27, 2023

View reviewed changes

Address comments

371a6b8

modular-magician requested a review from roaks3 November 28, 2023 22:48

Change back to use GetTestOrgFromEnv in testing

3df5948

roaks3 reviewed Nov 30, 2023

View reviewed changes

.../terraform/services/securitycenter/resource_scc_event_threat_detection_custom_module_test.go Show resolved Hide resolved

roaks3 self-requested a review November 30, 2023 18:11

roaks3 requested changes Nov 30, 2023

View reviewed changes

Improve test example

165f6ae

modular-magician requested a review from roaks3 November 30, 2023 23:01

Change parameter type to be immutable

8362423

roaks3 approved these changes Dec 1, 2023

View reviewed changes

roaks3 merged commit 89588b2 into GoogleCloudPlatform:main Dec 1, 2023
14 of 15 checks passed

rileykarson mentioned this pull request Dec 1, 2023

Security Command Center Custom Module for Event Thread Detection hashicorp/terraform-provider-google#16294

Closed

rileykarson reviewed Dec 1, 2023

View reviewed changes

mmv1/products/securitycenter/EventThreatDetectionCustomModule.yaml Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add resource EventThreatDetectionCustomModule #9509

Add resource EventThreatDetectionCustomModule #9509

luobopi commented Nov 21, 2023 •

edited by roaks3

modular-magician commented Nov 21, 2023

modular-magician commented Nov 21, 2023

modular-magician commented Nov 21, 2023

modular-magician commented Nov 22, 2023

modular-magician commented Nov 22, 2023

modular-magician commented Nov 22, 2023

modular-magician commented Nov 22, 2023

modular-magician commented Nov 22, 2023

roaks3 left a comment

modular-magician commented Nov 28, 2023

modular-magician commented Nov 29, 2023

modular-magician commented Nov 29, 2023

modular-magician commented Nov 29, 2023

modular-magician commented Nov 29, 2023

modular-magician commented Nov 29, 2023

roaks3 left a comment

modular-magician commented Nov 30, 2023

modular-magician commented Dec 1, 2023

modular-magician commented Dec 1, 2023

modular-magician commented Dec 1, 2023

roaks3 left a comment

modular-magician commented Dec 1, 2023

modular-magician commented Dec 1, 2023

roaks3 commented Dec 1, 2023

Add resource EventThreatDetectionCustomModule #9509

Add resource EventThreatDetectionCustomModule #9509

Conversation

luobopi commented Nov 21, 2023 • edited by roaks3

modular-magician commented Nov 21, 2023

modular-magician commented Nov 21, 2023

Diff report

modular-magician commented Nov 21, 2023

Diff report

modular-magician commented Nov 22, 2023

Tests analytics

Action taken

modular-magician commented Nov 22, 2023

modular-magician commented Nov 22, 2023

Diff report

modular-magician commented Nov 22, 2023

Tests analytics

Action taken

modular-magician commented Nov 22, 2023

Rerun these tests in REPLAYING mode to catch issues

roaks3 left a comment

Choose a reason for hiding this comment

modular-magician commented Nov 28, 2023

Diff report

modular-magician commented Nov 29, 2023

Tests analytics

Action taken

modular-magician commented Nov 29, 2023

modular-magician commented Nov 29, 2023

Diff report

modular-magician commented Nov 29, 2023

Tests analytics

Action taken

modular-magician commented Nov 29, 2023

Rerun these tests in REPLAYING mode to catch issues

roaks3 left a comment

Choose a reason for hiding this comment

modular-magician commented Nov 30, 2023

Diff report

modular-magician commented Dec 1, 2023

Tests analytics

Action taken

modular-magician commented Dec 1, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Dec 1, 2023

Diff report

roaks3 left a comment

Choose a reason for hiding this comment

modular-magician commented Dec 1, 2023

Tests analytics

Action taken

modular-magician commented Dec 1, 2023

Rerun these tests in REPLAYING mode to catch issues

roaks3 commented Dec 1, 2023

luobopi commented Nov 21, 2023 •

edited by roaks3