Add client, permissions, monitoring and mfa configs to google_identity_platform_config #9609

gleichda · 2023-12-08T16:40:09Z

Add client, permissions, monitoring and mfa configs to google_identity_platform_config

For client this also fixes the diff that was introduced in #9417 and reverted in #9447

Fixes hashicorp/terraform-provider-google/issues/14192
Fixes hashicorp/terraform-provider-google/issues/15712
Fixes hashicorp/terraform-provider-google/issues/13326
Fixes hashicorp/terraform-provider-google/issues/17063
Relates to: hashicorp/terraform-provider-google/issues/14194

Release Note Template for Downstream PRs (will be copied)

identityplatform: added `client`, `permissions`, `monitoring` and `mfa` fields to `google_identity_platform_config`

…m_config (GoogleCloudPlatform#9417)" This reverts commit 1c1f4d2.

modular-magician · 2023-12-08T16:41:52Z

Hello! I am a robot. It looks like you are a: ~~Community Contributor~~ Googler ~~Core Contributor~~. Tests will run automatically.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-12-08T16:50:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 588 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 588 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 1 file changed, 269 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_identity_platform_config (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_identity_platform_config" "primary" {
  client {
    api_key            = # value needed
    firebase_subdomain = # value needed
  }
  mfa {
    enabled_providers = # value needed
    provider_configs {
      state = # value needed
      totp_provider_config {
        adjacent_intervals = # value needed
      }
    }
    state = # value needed
  }
  monitoring {
    request_logging {
      enabled = # value needed
    }
  }
  multi_tenant {
    allow_tenants           = # value needed
    default_tenant_location = # value needed
  }
}

modular-magician · 2023-12-08T18:02:57Z

Tests analytics

Total tests: 3275
Passed tests 2941
Skipped tests: 334
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

mmv1/templates/terraform/examples/identity_platform_config_minimal.tf.erb

zli82016 · 2023-12-08T22:51:08Z

Also, can you please add the new fields to the update test to make sure updating the new fields is working? Thanks.

https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/identityplatform/resource_identity_platform_config_test.go

modular-magician · 2023-12-12T14:44:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 609 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 609 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 1 file changed, 269 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_identity_platform_config (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_identity_platform_config" "primary" {
  client {
    api_key            = # value needed
    firebase_subdomain = # value needed
  }
}

modular-magician · 2023-12-12T15:42:50Z

Tests analytics

Total tests: 3290
Passed tests 2951
Skipped tests: 337
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccIdentityPlatformConfig_identityPlatformConfigMinimalExample

Get to know how VCR tests work

modular-magician · 2023-12-12T15:53:02Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIdentityPlatformConfig_identityPlatformConfigMinimalExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

mmv1/templates/terraform/examples/identity_platform_config_minimal.tf.erb

modular-magician · 2023-12-14T22:47:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 666 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 4 files changed, 666 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 1 file changed, 269 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_identity_platform_config (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_identity_platform_config" "primary" {
  client {
    api_key            = # value needed
    firebase_subdomain = # value needed
  }
}

modular-magician · 2023-12-14T23:45:03Z

Tests analytics

Total tests: 3296
Passed tests 2958
Skipped tests: 337
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIdentityPlatformConfig_identityPlatformConfigMinimalExample

Get to know how VCR tests work

modular-magician · 2023-12-14T23:49:56Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIdentityPlatformConfig_identityPlatformConfigMinimalExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

zli82016 · 2023-12-15T01:02:54Z

mmv1/products/identityplatform/Config.yaml

+    name: 'client'
+    description: |
+      Options related to how clients making requests on behalf of a project should be configured.
+    ignore_read: true


I wonder what is the reason to add ignore_read ?

Ignore read is added here because the API always returns the default values for multiple fields.

resource "google_identity_platform_config" "default" { project = "MYPROJECTID" }

produces the following TF debug snippet:

2023-12-15T14:09:53.082Z [DEBUG] provider.terraform-provider-google: 2023/12/15 14:09:53 [DEBUG] Google API Request Details: 2023-12-15T14:09:53.082Z [DEBUG] provider.terraform-provider-google: ---[ REQUEST ]--------------------------------------- 2023-12-15T14:09:53.082Z [DEBUG] provider.terraform-provider-google: GET /v2/projects/MYPROJECTID/config?alt=json HTTP/1.1 2023-12-15T14:09:53.082Z [DEBUG] provider.terraform-provider-google: Host: identitytoolkit.googleapis.com 2023-12-15T14:09:53.082Z [DEBUG] provider.terraform-provider-google: User-Agent: Terraform/1.6.1 (+https://www.terraform.io) Terraform-Plugin-SDK/2.10.1 terraform-provider-google/dev 2023-12-15T14:09:53.082Z [DEBUG] provider.terraform-provider-google: Content-Type: application/json 2023-12-15T14:09:53.082Z [DEBUG] provider.terraform-provider-google: X-Goog-User-Project: gleichda-xyz-demo 2023-12-15T14:09:53.082Z [DEBUG] provider.terraform-provider-google: Accept-Encoding: gzip 2023-12-15T14:09:53.082Z [DEBUG] provider.terraform-provider-google 2023-12-15T14:09:53.082Z [DEBUG] provider.terraform-provider-google 2023-12-15T14:09:53.082Z [DEBUG] provider.terraform-provider-google: ----------------------------------------------------- 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: 2023/12/15 14:09:53 [DEBUG] Google API Response Details: 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: ---[ RESPONSE ]-------------------------------------- 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: HTTP/2.0 200 OK 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: Cache-Control: no-cache, no-store, max-age=0, must-revalidate 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: Content-Type: application/json; charset=UTF-8 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: Date: Fri, 15 Dec 2023 14:09:53 GMT 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: Expires: Mon, 01 Jan 1990 00:00:00 GMT 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: Pragma: no-cache 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: Server: ESF 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: Vary: Origin 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: Vary: X-Origin 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: Vary: Referer 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: X-Content-Type-Options: nosniff 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: X-Frame-Options: SAMEORIGIN 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: X-Xss-Protection: 0 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "name": "projects/141423373225/config", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "signIn": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "email": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "enabled": true 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: }, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "phoneNumber": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "enabled": true, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "testPhoneNumbers": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "+11231231234": "000000" 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: } 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: }, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "anonymous": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "enabled": true 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: }, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "allowDuplicateEmails": true, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "hashConfig": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "algorithm": "SCRYPT", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "signerKey": "ocDgh1Kx2zrbQrzKZjKeQ5J0Cl4RALqSBBPi2+ZheygcJ75wsWc9uBWvokCWz8GrSLnhtEXfN+4s4S1Zzgz09A==", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "saltSeparator": "Bw==", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "rounds": 8, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "memoryCost": 14 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: } 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: }, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "notification": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "sendEmail": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "method": "DEFAULT", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "resetPasswordTemplate": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "senderLocalPart": "noreply", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "subject": "Reset your password for %APP_NAME%", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "body": "\u003cp\u003eHello,\u003c/p\u003e\n\u003cp\u003eFollow this link to reset your %APP_NAME% password for your %EMAIL% account.\u003c/p\u003e\n\u003cp\u003e\u003ca href='%LINK%'\u003e%LINK%\u003c/a\u003e\u003c/p\u003e\n\u003cp\u003eIf you didn’t ask to reset your password, you can ignore this email.\u003c/p\u003e\n\u003cp\u003eThanks,\u003c/p\u003e\n\u003cp\u003eYour %APP_NAME% team\u003c/p\u003e", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "bodyFormat": "HTML", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "replyTo": "noreply" 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: }, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "verifyEmailTemplate": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "senderLocalPart": "noreply", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "subject": "Verify your email for %APP_NAME%", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "body": "\u003cp\u003eHello %DISPLAY_NAME%,\u003c/p\u003e\n\u003cp\u003eFollow this link to verify your email address.\u003c/p\u003e\n\u003cp\u003e\u003ca href='%LINK%'\u003e%LINK%\u003c/a\u003e\u003c/p\u003e\n\u003cp\u003eIf you didn’t ask to verify this address, you can ignore this email.\u003c/p\u003e\n\u003cp\u003eThanks,\u003c/p\u003e\n\u003cp\u003eYour %APP_NAME% team\u003c/p\u003e", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "bodyFormat": "HTML", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "replyTo": "noreply" 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: }, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "changeEmailTemplate": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "senderLocalPart": "noreply", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "subject": "Your sign-in email was changed for %APP_NAME%", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "body": "\u003cp\u003eHello %DISPLAY_NAME%,\u003c/p\u003e\n\u003cp\u003eYour sign-in email for %APP_NAME% was changed to %NEW_EMAIL%.\u003c/p\u003e\n\u003cp\u003eIf you didn’t ask to change your email, follow this link to reset your sign-in email.\u003c/p\u003e\n\u003cp\u003e\u003ca href='%LINK%'\u003e%LINK%\u003c/a\u003e\u003c/p\u003e\n\u003cp\u003eThanks,\u003c/p\u003e\n\u003cp\u003eYour %APP_NAME% team\u003c/p\u003e", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "bodyFormat": "HTML", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "replyTo": "noreply" 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: }, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "callbackUri": "https://MYPROJECTID.firebaseapp.com/__/auth/action", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "dnsInfo": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "customDomainState": "NOT_STARTED", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "domainVerificationRequestTime": "1970-01-01T00:00:00Z" 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: }, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "revertSecondFactorAdditionTemplate": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "senderLocalPart": "noreply", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "subject": "You've added 2 step verification to your %APP_NAME% account.", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "body": "\u003cp\u003eHello %DISPLAY_NAME%,\u003c/p\u003e\n\u003cp\u003eYour account in %APP_NAME% has been updated with %SECOND_FACTOR% for 2-step verification.\u003c/p\u003e\n\u003cp\u003eIf you didn't add this 2-step verification, click the link below to remove it.\u003c/p\u003e\n\u003cp\u003e\u003ca href='%LINK%'\u003e%LINK%\u003c/a\u003e\u003c/p\u003e\n\u003cp\u003eThanks,\u003c/p\u003e\n\u003cp\u003eYour %APP_NAME% team\u003c/p\u003e", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "bodyFormat": "HTML", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "replyTo": "noreply" 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: } 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: }, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "sendSms": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "smsTemplate": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "content": "%LOGIN_CODE% is your verification code for %APP_NAME%." 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: } 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: }, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "defaultLocale": "en" 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: }, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "quota": {}, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "monitoring": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "requestLogging": {} 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: }, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "multiTenant": {}, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "authorizedDomains": [ 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "localhost", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "MYPROJECTID.firebaseapp.com", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "MYPROJECTID.web.app" 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: ], 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "subtype": "IDENTITY_PLATFORM", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "client": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "apiKey": "REDACTED", 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "permissions": {}, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "firebaseSubdomain": "MYPROJECTID" 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: }, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "mfa": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "state": "DISABLED" 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: }, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "blockingFunctions": {}, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "smsRegionConfig": {}, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "autodeleteAnonymousUsers": true, 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "emailPrivacyConfig": { 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: "enableImprovedEmailPrivacy": true 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: } 2023-12-15T14:09:53.312Z [DEBUG] provider.terraform-provider-google: } 2023-12-15T14:09:53.313Z [DEBUG] provider.terraform-provider-google

Thanks for the information. Then default_from_api should be used here instead of ignore_read

mmv1/products/identityplatform/Config.yaml

zli82016 · 2023-12-15T01:08:05Z

mmv1/products/identityplatform/Config.yaml

+    name: 'mfa'
+    description: |
+      Options related to how clients making requests on behalf of a project should be configured.
+    ignore_read: true


I wonder what is the reason to add ignore_read ?

Same reason as in #9609 (comment)

default_from_api should be used here instead of ignore_read

zli82016 · 2023-12-15T01:08:15Z

mmv1/products/identityplatform/Config.yaml

+    name: 'monitoring'
+    description: |
+      Configuration related to monitoring project activity.
+    ignore_read: true


I wonder what is the reason to add ignore_read ?

Same reason as in #9609 (comment)

default_from_api should be used here instead of ignore_read

mmv1/products/identityplatform/Config.yaml

zli82016 · 2024-01-24T19:09:21Z

Passing this PR to @slevenick , as I am going to be OOO. Thanks, @slevenick .

…nto gcip

modular-magician · 2024-02-07T09:44:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 829 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 4 files changed, 829 insertions(+), 10 deletions(-))
TF Conversion: Diff ( 1 file changed, 272 insertions(+))

modular-magician · 2024-02-07T09:47:40Z

Tests analytics

Total tests: 16
Passed tests 14
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

identityplatform

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

gleichda · 2024-02-07T09:58:56Z

@slevenick Finally made it to finish the PR PTAL
(tagging you explicitly as I can't request a review)

slevenick

Just a couple small questions on the import state verify stuff.

Tests pass, so we should be good to go

slevenick · 2024-02-07T15:10:56Z

mmv1/third_party/terraform/services/identityplatform/resource_identity_platform_config_test.go

+				ResourceName:            "google_identity_platform_config.basic",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"client", "mfa", "monitoring"},


Why do we need ignore state verify here? If these are default_from_api it should just accept the server's value?

Fixed/or at least reduced to the outputs.
Without the outputs the test fail:

=== NAME TestAccIdentityPlatformConfig_identityPlatformConfigBasicExample vcr_utils.go:152: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected. (map[string]string) (len=1) { (string) (len=27) "client.0.firebase_subdomain": (string) (len=28) "tf-test-my-projectswbrzvojnv" } (map[string]string) (len=1) { (string) (len=27) "client.0.firebase_subdomain": (string) "" }

I'm not sure where this comes from but the actual expected is returned from the API therefor excluding this was my solution but happy to learn how to properly fix this

slevenick · 2024-02-07T15:13:37Z

mmv1/products/identityplatform/Config.yaml

@@ -49,6 +49,9 @@ examples:
    test_vars_overrides:
      # Set quota start time for the following day.
      quota_start_time: 'time.Now().AddDate(0, 0, 1).Format(time.RFC3339)'
+    ignore_read_extra:


We shouldn't need ignore_read_extra for output-only values I think?

Same as above:
without the ingore read for the outputs the test fails: (This also feels a little bit flaky not happening every time but regularly)

=== NAME TestAccIdentityPlatformConfig_identityPlatformConfigBasicExample vcr_utils.go:152: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected. (map[string]string) (len=1) { (string) (len=27) "client.0.firebase_subdomain": (string) (len=28) "tf-test-my-projectswbrzvojnv" } (map[string]string) (len=1) { (string) (len=27) "client.0.firebase_subdomain": (string) "" } ```

modular-magician · 2024-02-08T14:55:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 833 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 4 files changed, 833 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 1 file changed, 272 insertions(+))

modular-magician · 2024-02-08T14:58:42Z

Tests analytics

Total tests: 16
Passed tests 14
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

identityplatform

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Stale

…y_platform_config (GoogleCloudPlatform#9609) * Reapply "Add client config and permissions to google_identity_platform_config (GoogleCloudPlatform#9417)" This reverts commit 1c1f4d2. * Fix diff from API for GCIP client * Add mfa config to GCIP * Add multiTenant to google_identity_platform_config * Add monitoring and request Logging to google_identity_platform_config * Add test cases * Extend update test to the new attributes * Findings from review * First set of review findings from zli82016 * Fix monitoring permadiff via custom flatten * Fix client.permissions permadiff via custom flatten * Fix mfa.state permadiff * Adapt tests to latest changes * Ignore only outputs for the import verify

gleichda added 5 commits December 8, 2023 09:18

Reapply "Add client config and permissions to google_identity_platfor…

5eee1c1

…m_config (GoogleCloudPlatform#9417)" This reverts commit 1c1f4d2.

Fix diff from API for GCIP client

856eb7b

Add mfa config to GCIP

3446233

Add multiTenant to google_identity_platform_config

f34a790

Add monitoring and request Logging to google_identity_platform_config

9446996

modular-magician requested a review from zli82016 December 8, 2023 16:41

modular-magician added the service/identitytoolkit label Dec 8, 2023

zli82016 reviewed Dec 8, 2023

View reviewed changes

mmv1/templates/terraform/examples/identity_platform_config_minimal.tf.erb Show resolved Hide resolved

Add test cases

b87359f

modular-magician requested a review from zli82016 December 12, 2023 14:34

zli82016 reviewed Dec 12, 2023

View reviewed changes

mmv1/templates/terraform/examples/identity_platform_config_minimal.tf.erb Outdated Show resolved Hide resolved

gleichda marked this pull request as draft December 13, 2023 17:28

Extend update test to the new attributes

48d79ad

modular-magician requested a review from zli82016 December 14, 2023 22:37

gleichda marked this pull request as ready for review December 14, 2023 22:42

zli82016 reviewed Dec 15, 2023

View reviewed changes

mmv1/products/identityplatform/Config.yaml Outdated Show resolved Hide resolved

zli82016 reviewed Dec 15, 2023

View reviewed changes

mmv1/products/identityplatform/Config.yaml Outdated Show resolved Hide resolved

zli82016 requested review from a team and slevenick and removed request for zli82016 and a team January 24, 2024 17:43

gleichda added 5 commits February 6, 2024 19:05

Fix monitoring permadiff via custom flatten

273cb66

Fix client.permissions permadiff via custom flatten

d04011e

Fix mfa.state permadiff

b3752a0

Merge branch 'main' of github.com:GoogleCloudPlatform/magic-modules i…

0677465

…nto gcip

Adapt tests to latest changes

b9715bd

modular-magician requested a review from zli82016 February 7, 2024 09:35

slevenick reviewed Feb 7, 2024

View reviewed changes

Ignore only outputs for the import verify

b92edbc

modular-magician requested a review from slevenick February 8, 2024 14:45

slevenick approved these changes Feb 8, 2024

View reviewed changes

slevenick merged commit 6029bee into GoogleCloudPlatform:main Feb 8, 2024
13 checks passed

gleichda deleted the gcip branch February 14, 2024 13:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add client, permissions, monitoring and mfa configs to google_identity_platform_config #9609

Add client, permissions, monitoring and mfa configs to google_identity_platform_config #9609

gleichda commented Dec 8, 2023 •

edited

modular-magician commented Dec 8, 2023

modular-magician commented Dec 8, 2023

modular-magician commented Dec 8, 2023

zli82016 commented Dec 8, 2023 •

edited

modular-magician commented Dec 12, 2023

modular-magician commented Dec 12, 2023

modular-magician commented Dec 12, 2023

modular-magician commented Dec 14, 2023

modular-magician commented Dec 14, 2023

modular-magician commented Dec 14, 2023

zli82016 Dec 15, 2023

gleichda Dec 15, 2023 •

edited

zli82016 Dec 15, 2023

zli82016 Dec 15, 2023

gleichda Dec 15, 2023

zli82016 Dec 15, 2023

zli82016 Dec 15, 2023

gleichda Dec 15, 2023

zli82016 Dec 15, 2023

zli82016 commented Jan 24, 2024 •

edited

modular-magician commented Feb 7, 2024

modular-magician commented Feb 7, 2024

gleichda commented Feb 7, 2024

slevenick left a comment

slevenick Feb 7, 2024

gleichda Feb 8, 2024

slevenick Feb 7, 2024

gleichda Feb 8, 2024 •

edited

modular-magician commented Feb 8, 2024

modular-magician commented Feb 8, 2024

Add client, permissions, monitoring and mfa configs to google_identity_platform_config #9609

Add client, permissions, monitoring and mfa configs to google_identity_platform_config #9609

Conversation

gleichda commented Dec 8, 2023 • edited

modular-magician commented Dec 8, 2023

modular-magician commented Dec 8, 2023

Diff report

Missing test report

modular-magician commented Dec 8, 2023

Tests analytics

zli82016 commented Dec 8, 2023 • edited

modular-magician commented Dec 12, 2023

Diff report

Missing test report

modular-magician commented Dec 12, 2023

Tests analytics

Action taken

modular-magician commented Dec 12, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Dec 14, 2023

Diff report

Missing test report

modular-magician commented Dec 14, 2023

Tests analytics

Action taken

modular-magician commented Dec 14, 2023

Rerun these tests in REPLAYING mode to catch issues

Choose a reason for hiding this comment

gleichda Dec 15, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zli82016 commented Jan 24, 2024 • edited

modular-magician commented Feb 7, 2024

Diff report

modular-magician commented Feb 7, 2024

Tests analytics

gleichda commented Feb 7, 2024

slevenick left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gleichda Feb 8, 2024 • edited

Choose a reason for hiding this comment

modular-magician commented Feb 8, 2024

Diff report

modular-magician commented Feb 8, 2024

Tests analytics

gleichda commented Dec 8, 2023 •

edited

zli82016 commented Dec 8, 2023 •

edited

gleichda Dec 15, 2023 •

edited

zli82016 commented Jan 24, 2024 •

edited

gleichda Feb 8, 2024 •

edited