-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-place update labels
and terraform_labels
fields in immutable resources
#9697
Conversation
a89fc27
to
2cf2f36
Compare
/gcbrun |
1 similar comment
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 20 files changed, 65 insertions(+), 19 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
b0b477f
to
c69cd1a
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 21 files changed, 65 insertions(+), 20 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
c69cd1a
to
39e9762
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 21 files changed, 65 insertions(+), 20 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
39e9762
to
1f49d88
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 22 files changed, 72 insertions(+), 22 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
labels
and terraform_labels
fields in immutable resources
The changes made to resources lgtm- I didn't extensively verify the completeness of the change. |
…esources (GoogleCloudPlatform#9697) * Make labels and terraform_labels mutable for immutable resources * Update labels and terraform_labels in-place for immutable resources
…esources (GoogleCloudPlatform#9697) * Make labels and terraform_labels mutable for immutable resources * Update labels and terraform_labels in-place for immutable resources
…esources (GoogleCloudPlatform#9697) * Make labels and terraform_labels mutable for immutable resources * Update labels and terraform_labels in-place for immutable resources
…esources (GoogleCloudPlatform#9697) * Make labels and terraform_labels mutable for immutable resources * Update labels and terraform_labels in-place for immutable resources
For immutable resources, add update method and remove ForceNew from
labels
andterraform_labels
fields, so these two fields will be updated in place.This change applied to all of the immutable resources with immutable
terraform_labels
and immutablelabels
fieldsRelease Note Template for Downstream PRs (will be copied)