Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-place update labels and terraform_labels fields in immutable resources #9697

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Dec 21, 2023

For immutable resources, add update method and remove ForceNew from labels and terraform_labels fields, so these two fields will be updated in place.

This change applied to all of the immutable resources with immutable terraform_labels and immutable labels fields

Release Note Template for Downstream PRs (will be copied)

provider: added support for in-place update for `labels` and `terraform_labels` fields in immutable resources

@zli82016 zli82016 force-pushed the labels-immutable-resources-update branch 5 times, most recently from a89fc27 to 2cf2f36 Compare December 21, 2023 19:26
@melinath
Copy link
Member

/gcbrun

1 similar comment
@melinath
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 20 files changed, 65 insertions(+), 19 deletions(-))
Terraform Beta: Diff ( 21 files changed, 72 insertions(+), 21 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 216
Passed tests 200
Skipped tests: 16
Affected tests: 0

Click here to see the affected service packages
  • edgecontainer
  • networkconnectivity
  • mlengine
  • beyondcorp
  • databasemigrationservice
  • certificatemanager
  • networkservices
  • tpu
  • datastream
  • securesourcemanager
  • bigquery

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@zli82016 zli82016 force-pushed the labels-immutable-resources-update branch 3 times, most recently from b0b477f to c69cd1a Compare January 4, 2024 20:29
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 21 files changed, 65 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 22 files changed, 72 insertions(+), 22 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 273
Passed tests 252
Skipped tests: 21
Affected tests: 0

Click here to see the affected service packages
  • edgecontainer
  • networkconnectivity
  • mlengine
  • beyondcorp
  • databasemigrationservice
  • dataproc
  • certificatemanager
  • networkservices
  • tpu
  • datastream
  • securesourcemanager
  • bigquery

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@zli82016 zli82016 force-pushed the labels-immutable-resources-update branch from c69cd1a to 39e9762 Compare January 5, 2024 18:12
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 21 files changed, 65 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 22 files changed, 72 insertions(+), 22 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 273
Passed tests 252
Skipped tests: 21
Affected tests: 0

Click here to see the affected service packages
  • edgecontainer
  • networkconnectivity
  • mlengine
  • beyondcorp
  • databasemigrationservice
  • dataproc
  • certificatemanager
  • networkservices
  • tpu
  • datastream
  • securesourcemanager
  • bigquery

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@zli82016 zli82016 force-pushed the labels-immutable-resources-update branch from 39e9762 to 1f49d88 Compare January 5, 2024 22:40
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 72 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 23 files changed, 79 insertions(+), 24 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 273
Passed tests 252
Skipped tests: 21
Affected tests: 0

Click here to see the affected service packages
  • edgecontainer
  • networkconnectivity
  • mlengine
  • beyondcorp
  • databasemigrationservice
  • dataproc
  • certificatemanager
  • networkservices
  • tpu
  • datastream
  • securesourcemanager
  • bigquery

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@zli82016 zli82016 changed the title test In-place update labels and terraform_labels fields in immutable resources Jan 8, 2024
@rileykarson
Copy link
Member

The changes made to resources lgtm- I didn't extensively verify the completeness of the change.

@zli82016 zli82016 merged commit ed97eb3 into main Jan 16, 2024
15 checks passed
@zli82016 zli82016 deleted the labels-immutable-resources-update branch January 16, 2024 22:50
bskaplan pushed a commit to bskaplan/magic-modules that referenced this pull request Jan 17, 2024
…esources (GoogleCloudPlatform#9697)

* Make labels and terraform_labels mutable for immutable resources

* Update labels and terraform_labels in-place for immutable resources
kylase pushed a commit to yuanchuankee/magic-modules that referenced this pull request Jan 21, 2024
…esources (GoogleCloudPlatform#9697)

* Make labels and terraform_labels mutable for immutable resources

* Update labels and terraform_labels in-place for immutable resources
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
…esources (GoogleCloudPlatform#9697)

* Make labels and terraform_labels mutable for immutable resources

* Update labels and terraform_labels in-place for immutable resources
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
…esources (GoogleCloudPlatform#9697)

* Make labels and terraform_labels mutable for immutable resources

* Update labels and terraform_labels in-place for immutable resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants