Add error handling for ALREADY_EXISTS in IAM CreateServiceAccount call

[benhxy]

Introduce an optional resource argument to Google Cloud IAM Service Account. If ignore_create_already_exists is set to true, resource creation would succeed if response error is 409 ALREADY_EXISTS.

Fixes hashicorp/terraform-provider-google#16185
Fixes hashicorp/terraform-provider-google#10193

Release Note Template for Downstream PRs (will be copied)

iam: introducde an optional resource argument to Google Cloud IAM Service Account. If `ignore_create_already_exists` is set to true, resource creation would succeed if response error is 409 ALREADY_EXISTS.

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 33 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 33 insertions(+), 1 deletion(-))

[benhxy]

To reviewer: an alternative argument name could be create_ignore_already_exists. Please advise if there are better names.

[modular-magician]

Tests analytics

Total tests: 135
Passed tests 103
Skipped tests: 30
Affected tests: 2

Click here to see the affected service packages

• resourcemanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccServiceAccount_basic|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccServiceAccount_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 65 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 65 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 75 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 75 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

[benhxy]

Hmm I'm a bit stuck on the build error. When I clicked in the build log, it only has one line:

FAIL	github.com/hashicorp/terraform-provider-google-beta/google-beta/services/resourcemanager [build failed]

Locally, I followed https://googlecloudplatform.github.io/magic-modules/get-started/generate-providers/ to set up the environment.

Then with my change in magic-modules, I ran make provider VERSION=beta OUTPUT_PATH="$GOPATH/src/github.com/hashicorp/terraform-provider-google-beta" PRODUCT=resourcemanager RESOURCE=google_service_account.

It showed a lot of /Users/bensea/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/bundler-2.4.6/lib/bundler/shared_helpers.rb:58:in getwd': Too many open files - getcwd (Errno::EMFILE)` but that probably didn't matter.

It also updated many other products even when I specified PRODUCT and RESOURCE filter.

But most importantly, it didn't update the files I edited in magic-modules:

terraform-provider-google-beta bensea$ git status | grep resourcemanager
	modified:   google-beta/services/resourcemanager/data_source_google_folders.go
	modified:   google-beta/services/resourcemanager/data_source_google_iam_testable_permissions_test.go
	modified:   google-beta/services/resourcemanager/data_source_google_organization.go
	modified:   google-beta/services/resourcemanager/data_source_google_organization_test.go
	modified:   google-beta/services/resourcemanager/data_source_google_project_organization_policy.go
	modified:   google-beta/services/resourcemanager/data_source_google_project_service.go
	modified:   google-beta/services/resourcemanager/data_source_google_project_service_test.go
	modified:   google-beta/services/resourcemanager/data_source_google_projects.go
	modified:   google-beta/services/resourcemanager/data_source_google_projects_test.go
	modified:   google-beta/services/resourcemanager/data_source_google_service_account.go
	modified:   google-beta/services/resourcemanager/data_source_google_service_account_access_token.go
	modified:   google-beta/services/resourcemanager/data_source_google_service_account_access_token_test.go
	modified:   google-beta/services/resourcemanager/data_source_google_service_account_id_token.go
	modified:   google-beta/services/resourcemanager/data_source_google_service_account_id_token_test.go
	modified:   google-beta/services/resourcemanager/data_source_google_service_account_jwt_test.go
	modified:   google-beta/services/resourcemanager/resource_google_project_migrate_test.go
	modified:   google-beta/services/resourcemanager/resource_google_service_account_key_test.go
	modified:   google-beta/services/resourcemanager/resource_google_service_account_sweeper.go

@rileykarson appreciate your help here.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 76 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 76 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 136
Passed tests 105
Skipped tests: 30
Affected tests: 1

Click here to see the affected service packages

• resourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccServiceAccount_createIgnoreAlreadyExists

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{The provider crashed while running the VCR tests in RECORDING mode}}$
$\textcolor{red}{\textsf{Please fix it to complete your PR}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 78 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 78 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 136
Passed tests 105
Skipped tests: 30
Affected tests: 1

Click here to see the affected service packages

• resourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccServiceAccount_createIgnoreAlreadyExists

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{The provider crashed while running the VCR tests in RECORDING mode}}$
$\textcolor{red}{\textsf{Please fix it to complete your PR}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 80 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 80 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 136
Passed tests 105
Skipped tests: 30
Affected tests: 1

Click here to see the affected service packages

• resourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccServiceAccount_createIgnoreAlreadyExists

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccServiceAccount_createIgnoreAlreadyExists[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[benhxy]

Tests are fixed.