Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where timeout isn't being passed to storage bucket call #9753

Conversation

ScottSuarez
Copy link
Contributor

@ScottSuarez ScottSuarez commented Jan 4, 2024

causing a issue in b/318202148

Release Note Template for Downstream PRs (will be copied)

storage: fixed issue where retry timeout wasn't being utilized during create of `google_storage_bucket`

@ScottSuarez ScottSuarez changed the title Timeout isn't being passed to storage bucket call.. Fixed issue where timeout isn't being passed to storage bucket call Jan 4, 2024
@ScottSuarez ScottSuarez requested review from a team and rileykarson and removed request for a team January 4, 2024 18:51
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 89
Passed tests 83
Skipped tests: 6
Affected tests: 0

Click here to see the affected service packages
  • storage

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@netzere
Copy link

netzere commented Jan 9, 2024

Hi @ScottSuarez, thanks for this fix :)
I'm wondering whether there might be other resources under the GCP provider who suffer from this issue?
is there any "global" way to make sure other resources don't have this issue as well?

Moreover, when can we expect this fix to be released to the GCP Terraform provider?

@ScottSuarez
Copy link
Contributor Author

ScottSuarez commented Jan 9, 2024

I'm not sure.
Our transport layer doesn't require timeout to be passed in. So one could check all consumers where this is the case to spot any outliers.

It should only apply to handwritten resources.. auto gen resources won't have this concern..

Release shall be next Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants