Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support connectivity fields for Composer 3 #9889

Merged
merged 41 commits into from
Feb 26, 2024
Merged

Support connectivity fields for Composer 3 #9889

merged 41 commits into from
Feb 26, 2024

Commits on Dec 6, 2023

  1. add composer_network_attachment

    @spapi17
    spapi17 committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    fbb1a7d View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. indicate conflicting configs

    @spapi17
    spapi17 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    ba9a1f5 View commit details
    Browse the repository at this point in the history

  2. commas

    @spapi17
    spapi17 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    c68d7c7 View commit details
    Browse the repository at this point in the history

  3. no need for bidirectional conflict definition (generates double errors)

    @spapi17
    spapi17 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    83a24e3 View commit details
    Browse the repository at this point in the history

  4. protect nit PrivateClusterConfig

    @spapi17
    spapi17 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    53ed66b View commit details
    Browse the repository at this point in the history

  5. for optimizing error messages about conflicts

    @spapi17
    spapi17 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    4ecb5cd View commit details
    Browse the repository at this point in the history

  6. add 2 step update for composer_network_attachment

    @spapi17
    spapi17 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    34f9c5f View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. make composer_network_attachment available in beta only

    @spapi17
    spapi17 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    3713ba3 View commit details
    Browse the repository at this point in the history

  2. add two step update for network and subnetwork

    @spapi17
    spapi17 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    4898509 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into network

    @spapi17
    spapi17 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    aa9c9d4 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. corrections in 2 phase update for network/subnetwork

    @spapi17
    spapi17 committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    33db174 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Merge branch 'GoogleCloudPlatform:main' into network

    @spapi17
    spapi17 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    713e34e View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. remove composer3 check(CustomizeDiff will solve this), filter api err… 

    …or, add tests (unsetting netwok/subnetwork not working)
    @spapi17
    spapi17 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    654aec6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'GoogleCloudPlatform:main' into network

    @spapi17
    spapi17 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    e4f61ed View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. merge main

    @spapi17
    spapi17 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    5383cf6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into network

    @spapi17
    spapi17 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    4239e3a View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. added ForceNewIf fot network/subnetwork, problem with unsetting these… 

    … fields remains
    @spapi17
    spapi17 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    f719deb View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. add docs for composer_network_attachment

    @spapi17
    spapi17 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    51bf71a View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. add test for network attachment

    @spapi17
    spapi17 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ac103fc View commit details
    Browse the repository at this point in the history

  2. ignore non empty plan in network attachment test

    @spapi17
    spapi17 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    0ce121e View commit details
    Browse the repository at this point in the history

  3. add networkAttachment update and conflicting fields tests

    @spapi17
    spapi17 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    4d48140 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. add ComputedIf for network, change isComposer3

    @spapi17
    spapi17 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    0b3c252 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into network

    @spapi17
    spapi17 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    29e4dd7 View commit details
    Browse the repository at this point in the history

  3. minor corrections

    @spapi17
    spapi17 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    4546db2 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. remove computedIf

    @spapi17
    spapi17 committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    b3cbf7b View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. filter equivalent values of network/subnetwork in ForceNewIf

    @spapi17
    spapi17 committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    1f82190 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. simplify ResourceConditionFunc, add beta/ga version conditions

    @spapi17
    spapi17 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4a577a8 View commit details
    Browse the repository at this point in the history

  2. typo

    @spapi17
    spapi17 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4aa9684 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. more general comparison of network references

    @spapi17
    spapi17 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    62ce208 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. use tpgresource.CompareSelfLinkRelativePaths instead of custom function

    @spapi17
    spapi17 committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    4d3c0a5 View commit details
    Browse the repository at this point in the history

  2. modify isComposer3 to avoid merge conflicts later.

    @spapi17
    spapi17 committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b8d0f9e View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. removing this since documentation is handled in other PR and to avoid… 

    … conflicts while merging.
    @spapi17
    spapi17 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    3c129c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. replace ExpectNonEmptyPlan with lifecycle.ignore_changes

    @spapi17
    spapi17 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    9021018 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into network

    @spapi17
    spapi17 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    d293e8f View commit details
    Browse the repository at this point in the history

  3. add testcase for changing network attachment to network and subnetwork

    @spapi17
    spapi17 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    7ec49b0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'network' of github.com:spapi17/magic-modules into network

    @spapi17
    spapi17 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    6185aad View commit details
    Browse the repository at this point in the history

  5. add third step to TestAccComposerEnvironmentComposer3_updateWithNetwo… 

    …rkAndSubnetwork
    @spapi17
    spapi17 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    250452e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. modify tests to use different network for attachment

    @spapi17
    spapi17 committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    684adb9 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. remove unused constant

    @spapi17
    spapi17 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    1bf57c7 View commit details
    Browse the repository at this point in the history

  2. merge main

    @spapi17
    spapi17 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    321d558 View commit details
    Browse the repository at this point in the history

  3. remove ExpectNonEmptyPlan (already replaced with lifecycle.ignore_cha… 

    …nges)
    @spapi17
    spapi17 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    528f9d8 View commit details
    Browse the repository at this point in the history