Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppAttest and PlayIntegrity for App Check #9970

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

rainshen49
Copy link
Contributor

@rainshen49 rainshen49 commented Feb 12, 2024

Add support for Apple's App Attest provider and Android's Play Integrity provider for App Check.

Part of hashicorp/terraform-provider-google#17095

Release Note Template for Downstream PRs (will be copied)

`google_firebase_app_check_app_attest_config`
`google_firebase_app_check_play_integrity_config`

@rainshen49 rainshen49 requested a review from a team as a code owner February 12, 2024 20:09
@rainshen49 rainshen49 requested review from rileykarson and removed request for a team February 12, 2024 20:09
@rileykarson
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1389 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1389 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 138 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 6
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages
  • firebaseappcheck

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaseAppCheckAppAttestConfig_firebaseAppCheckAppAttestConfigFullExample|TestAccFirebaseAppCheckAppAttestConfig_firebaseAppCheckAppAttestConfigMinimalExample|TestAccFirebaseAppCheckAppAttestConfig_firebaseAppCheckAppAttestConfigUpdate|TestAccFirebaseAppCheckPlayIntegrityConfig_firebaseAppCheckPlayIntegrityConfigFullExample|TestAccFirebaseAppCheckPlayIntegrityConfig_firebaseAppCheckPlayIntegrityConfigMinimalExample|TestAccFirebaseAppCheckPlayIntegrityConfig_firebaseAppCheckPlayIntegrityConfigUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFirebaseAppCheckAppAttestConfig_firebaseAppCheckAppAttestConfigFullExample[Debug log]
TestAccFirebaseAppCheckAppAttestConfig_firebaseAppCheckAppAttestConfigMinimalExample[Debug log]
TestAccFirebaseAppCheckAppAttestConfig_firebaseAppCheckAppAttestConfigUpdate[Debug log]
TestAccFirebaseAppCheckPlayIntegrityConfig_firebaseAppCheckPlayIntegrityConfigFullExample[Debug log]
TestAccFirebaseAppCheckPlayIntegrityConfig_firebaseAppCheckPlayIntegrityConfigMinimalExample[Debug log]
TestAccFirebaseAppCheckPlayIntegrityConfig_firebaseAppCheckPlayIntegrityConfigUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@rileykarson rileykarson merged commit 5a6abe3 into GoogleCloudPlatform:main Feb 14, 2024
11 of 12 checks passed
tdbhacks pushed a commit to tdbhacks/magic-modules that referenced this pull request Feb 23, 2024
* AppAttest and PlayIntegrity for App Check

* use camelCase for updateMask for consistency

* Enhance examples to use precondition checks
@rainshen49 rainshen49 deleted the appcheck-appreg branch March 25, 2024 18:04
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
* AppAttest and PlayIntegrity for App Check

* use camelCase for updateMask for consistency

* Enhance examples to use precondition checks
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
* AppAttest and PlayIntegrity for App Check

* use camelCase for updateMask for consistency

* Enhance examples to use precondition checks
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
* AppAttest and PlayIntegrity for App Check

* use camelCase for updateMask for consistency

* Enhance examples to use precondition checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants