Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider separating service protos into different files #1

Closed
ahmetb opened this issue Aug 3, 2018 · 5 comments
Closed

Consider separating service protos into different files #1

ahmetb opened this issue Aug 3, 2018 · 5 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@ahmetb
Copy link
Contributor

ahmetb commented Aug 3, 2018

Currently all files are in a single proto.
https://github.com/GoogleCloudPlatform/microservices-demo/blob/4572974c882b7c159a59e5344a3aa42c7f4af040/pb/demo.proto

Ideally we should have per-service protos like pb/hipstershop/currencyservice.proto etc.
@ahmetb ahmetb mentioned this issue Aug 7, 2018
Closed
NipunaMarcus pushed a commit to NipunaMarcus/microservices-demo that referenced this issue Nov 16, 2019
@warunalakshitha
Merge pull request GoogleCloudPlatform#1 from sameerajayasoma/balleri…
a7e2b06 
…na_hackathon

Update README.md with Ballerina hackathon details
@daniel-sanche
Copy link
Member

Closing this and other kind/improvement issues as we attempt to move the project into a stable maintenance state

apsro07 added a commit to apsro07/microservices-demo that referenced this issue May 18, 2021
@apsro07
Updates: CI/CD demo update GoogleCloudPlatform#1
e9e39a0
@evekhm evekhm mentioned this issue Jun 21, 2021
Closed
@askmeegs askmeegs reopened this Nov 30, 2021
@askmeegs
Copy link
Contributor

Reopening to resume the discussion and triage.

@bourgeoisor bourgeoisor added priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern. and removed what/improvement labels Dec 1, 2021
@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Jun 7, 2022 •
edited
Loading

Good candidate to be tackle in #814 too.

@mathieu-benoit mathieu-benoit mentioned this issue Jun 7, 2022
Open
@NimJay
Copy link
Collaborator

NimJay commented Dec 7, 2022

Commenting to cool this issue down (from our team's out-of-SLO list):
We should still address this issue. I'll leave it open.

@NimJay NimJay removed the area/grpc label Dec 21, 2022
@HarikiRito HarikiRito mentioned this issue Dec 29, 2022
Closed
@bourgeoisor
Copy link
Member

Closing this issue in favour of the bigger-scope #814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ahmetb @askmeegs @bourgeoisor @daniel-sanche @NimJay @mathieu-benoit