Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider separating service protos into different files #1

Closed
ahmetb opened this issue Aug 3, 2018 · 5 comments
Closed

Consider separating service protos into different files #1

ahmetb opened this issue Aug 3, 2018 · 5 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@ahmetb
Copy link
Contributor

ahmetb commented Aug 3, 2018

Currently all files are in a single proto.
https://github.com/GoogleCloudPlatform/microservices-demo/blob/4572974c882b7c159a59e5344a3aa42c7f4af040/pb/demo.proto

Ideally we should have per-service protos like pb/hipstershop/currencyservice.proto etc.

NipunaMarcus pushed a commit to NipunaMarcus/microservices-demo that referenced this issue Nov 16, 2019
…na_hackathon

Update README.md with Ballerina hackathon details
@daniel-sanche
Copy link
Member

Closing this and other kind/improvement issues as we attempt to move the project into a stable maintenance state

@askmeegs
Copy link
Contributor

Reopening to resume the discussion and triage.

@bourgeoisor bourgeoisor added priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern. and removed what/improvement labels Dec 1, 2021
@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Jun 7, 2022

Good candidate to be tackle in #814 too.

@NimJay
Copy link
Collaborator

NimJay commented Dec 7, 2022

Commenting to cool this issue down (from our team's out-of-SLO list):
We should still address this issue. I'll leave it open.

@bourgeoisor
Copy link
Member

Closing this issue in favour of the bigger-scope #814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

6 participants