Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple release/ Manifests into Separate Files #375

Closed
askmeegs opened this issue Jul 27, 2020 · 4 comments
Closed

Decouple release/ Manifests into Separate Files #375

askmeegs opened this issue Jul 27, 2020 · 4 comments
Assignees
Labels
area/build area/istio area/kubernetes priority: p3 Desirable enhancement or fix. May not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Milestone

Comments

@askmeegs
Copy link
Contributor

Reason - make the release manifests more modular for kustomize / trainings.

Mirror the structure of kubernetes-manifests/*.yaml and update the hack/ release scripts to not concatenate all the YAML resources together.

@askmeegs askmeegs added this to the 🚲 Q2 2021 milestone Mar 23, 2021
@askmeegs askmeegs added priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like. and removed priority/P2 labels Apr 8, 2021
@askmeegs askmeegs self-assigned this May 21, 2021
@askmeegs askmeegs removed their assignment Jul 14, 2021
@NimJay NimJay changed the title Proposal: decouple release/ manifests into separate files Decouple release/ Manifests into Separate Files Nov 22, 2021
@bourgeoisor bourgeoisor self-assigned this Feb 8, 2022
@bourgeoisor
Copy link
Member

Started working on this here: #716

Note that this might be a tough change, since a lot of external content relies on being able to do kubectl apply -f ./release/kubernetes-manifests.yaml (the one-file manifest)

@NimJay
Copy link
Collaborator

NimJay commented Mar 25, 2022

Providing an update to cool it down from our "Out of SLO" list:
This project is still on pause because we still need to think about how we'll deal with the impact this will have on tutorials/docs using Online Boutique (i.e., running kubectl apply -f ./release/kubernetes-manifests.yaml).
We also need to think about its impact on the upcoming (2022 Q2) Kustomize integration.

@xtineskim xtineskim added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 6, 2022
@xtineskim
Copy link
Contributor

Cool down for OSLO again! I believe @NimJay made some progress on this

@bourgeoisor bourgeoisor added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 21, 2022
@bourgeoisor bourgeoisor removed their assignment Nov 1, 2022
@NimJay NimJay self-assigned this Nov 24, 2022
@NimJay
Copy link
Collaborator

NimJay commented Dec 1, 2022

We can close this GitHub issue now since:

We have not deleted /release/kubernetes-manifests.yaml yet since it's used by a lot of tutorials and demos.
We need to first update those tutorials and demos before deleting /release/kubernetes-manifests.yaml.

@NimJay NimJay closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build area/istio area/kubernetes priority: p3 Desirable enhancement or fix. May not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants