Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /kustomize/ in /terraform/ #1145

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Use /kustomize/ in /terraform/ #1145

merged 3 commits into from
Oct 14, 2022

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Oct 7, 2022

Background

  • We hope to eventually delete the all-encompassing /release/kubernetes-manifests.yaml file.
  • See the /kustomize/kustomization.yaml file. We want to use this for all Online Boutique deployments going forward.

Change Summary

  • Online Boutique's Terraform (./terraform) now uses the Kubernetes resources from /kustomize/base/ (via the /kustomize/kustomization.yaml file).

Additional Notes

Testing Procedure

Related PRs or Issues

@NimJay NimJay marked this pull request as ready for review October 7, 2022 15:31
@NimJay NimJay requested a review from a team as a code owner October 7, 2022 15:31
Copy link
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm`ed it assuming that all kustomize tests were already merged.

@NimJay
Copy link
Collaborator Author

NimJay commented Oct 10, 2022

assuming that all kustomize tests were already merged.

Unfortunately, the Terraform-related tests (inside the checks of this pull-request) only test terraform validate.
We will need to test terraform apply manually for now.

@NimJay
Copy link
Collaborator Author

NimJay commented Oct 14, 2022

Screen Shot 2022-10-14 at 10 47 07 AM

I just test this change (i.e., terraform apply with kubectl apply -k ../kustomize/).
Works!
Merging.

@NimJay NimJay merged commit f0bbb9c into main Oct 14, 2022
@NimJay NimJay deleted the nimjay/kustomize-for-terraform branch October 14, 2022 15:33
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
Co-authored-by: minherz <minherz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants