Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the use of Google Cloud Debugger #836

Closed
bourgeoisor opened this issue May 23, 2022 · 6 comments · Fixed by #1281
Closed

Deprecate the use of Google Cloud Debugger #836

bourgeoisor opened this issue May 23, 2022 · 6 comments · Fixed by #1281
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@bourgeoisor
Copy link
Member

Since Cloud Debugger is getting deprecated (doc: https://cloud.google.com/debugger/docs), we should remove it altogether and potentially replace it with Snapshot Debugger (https://github.com/GoogleCloudPlatform/snapshot-debugger)

Cloud Debugger is currently embedded in some services (for example, https://github.com/GoogleCloudPlatform/microservices-demo/blob/main/src/recommendationservice/recommendation_server.py#L128)

Additionally, we should look into closing any potentially-no-longer-relevant issues, for example:

@NimJay NimJay added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 24, 2022
@xtineskim
Copy link
Contributor

xtineskim commented May 24, 2022

Snapshot debugger only supports Node.js debug agent in preview mode still, looks like Python3 support will come eventually?
That being said, are there any fixes we can provide for the above issues linked?

@xtineskim
Copy link
Contributor

potentially related #713

@mathieu-benoit
Copy link
Contributor

Is it something you could help with during one of your next rotations @arbrown or @minherz?

@eti-tme-tim
Copy link

Can we ensure that the cloud debugger replacement also has corresponding aarch64 support?

@xtineskim
Copy link
Contributor

we can try to look into it! for now docs are showing that Cloud debugger will be deprecated May 31, 2023
(https://cloud.google.com/debugger/docs/deprecations)

@NimJay
Copy link
Collaborator

NimJay commented Nov 21, 2022

Thanks, @xtineskim, for pointing out that the Snapshot Debugger will lose support after Aug 31, 2023:

Snapshot Debugger and associated agents will be supported until Aug 31, 2023, after which they will be archived and frozen.

In that case, I don't think we should use Snapshot Debugger at all.
We should still remove all instances (inside Online Boutique) of Cloud Debugger being used.

@xtineskim xtineskim added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 23, 2022
@NimJay NimJay added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Nov 24, 2022
@NimJay NimJay self-assigned this Nov 24, 2022
@NimJay NimJay removed the priority: p3 Desirable enhancement or fix. May not be included in next release. label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants