Allow to have a unique user-id across sessions
#1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieu-benoit
changed the title
user-id across sessions
|
🚲 PR staged at http://34.118.205.234 |
NimJay
reviewed
Sep 2, 2022
|
🚲 PR staged at http://34.118.205.234 |
|
🚲 PR staged at http://34.118.205.234 |
|
Just did my tests, ready for your review, thanks! Sorry for the confusion while I was doing my test in draft mode, if there is still confusion or your need clarification, feel free to ping me :) The default behavior is still the same, now if someone wants a unique user id across sessions, they could use this env var |
|
🚲 PR staged at http://34.118.205.234 |
1 similar comment
|
🚲 PR staged at http://34.118.205.234 |
NimJay
approved these changes
Sep 3, 2022
mathieu-benoit
deleted the
mathieu-benoit/enable-unique-user-id-across-sessions
branch
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
…#1023) * ENABLE_UNIQUE_USER_ID_ACROSS_SESSIONS * Update middleware.go * fix ENABLE_UNIQUE_USER_ID_ACROSS_SESSIONS test with the value "true" * ENABLE_SINGLE_SHARED_SESSION
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new environment variable for the
frontendapp:ENABLE_SINGLE_SHARED_SESSION. This allows to have a unique User Id across the sessions. The default behavior is one User Id per session.Fixing #615 + allows more scenarios to showcase:
redisdatabase is just in 1 cluster, see that the data are accessible fromcartserviceandfrontendfrom different clusters.cartserviceandfrontendfrom different clusters.If you set this environment variable to
"true"on thefrontendapp, here is how to test this new behavior:user-idat the bottom of the website (associated cookie) with the value: ``. If you open your internet browser now in InPrivate/Incognito mode, you will see the same value.Notes:
frontend'sDeploymentmanifest or for example run this command:kubectl set env deployment/frontend ENABLE_SINGLE_SHARED_SESSION="true".