Update paymentservice uuid usage to v9
#1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NimJay
commented
Sep 19, 2022
| @@ -13,7 +13,7 @@ | |||
| // limitations under the License. | |||
|
|
|||
| const cardValidator = require('simple-card-validator'); | |||
| const uuid = require('uuid'); | |||
| const { v4: uuidv4 } = require('uuid'); | |||
There was a problem hiding this comment.
I just copied the official uuid npm package docs: https://www.npmjs.com/package/uuid.
bourgeoisor
approved these changes
Sep 19, 2022
|
🚲 PR staged at http://34.136.75.105 |
|
Thanks, Olivier, that was fast! All checks are passing.
|
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
* Update paymentservice uuid usage to v9 * Update paymentservice uuid npm package to v9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
paymentservice'suuiddependency tov9.0.0, I didn't updatepaymentserviceinvocation ofuuidincharge.js.paymentservice(see error logs from Revert "fix(deps): update dependency uuid to v9" #1070).Change Summary
Additional Notes
loadgenerator.mainbranch caught this error because it counts the errors seen by theloadgenerator: https://github.com/GoogleCloudPlatform/microservices-demo/actions/runs/3083297795/jobs/4984166585#step:5:1.Testing Procedure