Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port NetworkPolicy flavour to Kustomize #1081

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Sep 21, 2022

Background

Change Summary

  • This pull-request ports over the flavour with NetworkPolicy resources to Kustomize.

Testing Procedure

  1. Check out the source branch:
git checkout nimjay-kustomize-network-policy
  1. Uncomment the network-policy Kustomize Component inside kustomize/kustomization.yaml.
sed -i '' 's/# - components\/network-policy/- components\/network-policy/' kustomize/kustomization.yaml
  1. Check that Kustomize builds correctly.
# This is the same as "kustomize build".
kubectl kustomize ./kustomize/
  1. Check that the Kustomize build output includes the NetworkPolicy resources.
kubectl kustomize ./kustomize/ | grep NetworkPolicy

You'll notice that the NetworkPolicy resources are included in the Kustomize build.

Related PRs or Issues

@NimJay NimJay requested a review from a team as a code owner September 21, 2022 21:34
As an example, here is the option you need to use when creating your cluster:
```sh
gcloud container clusters create \
--enable-dataplane-v2
Copy link
Collaborator Author

@NimJay NimJay Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the step:

gcloud container clusters create \
    --enable-dataplane-v2

because these GKE-specific instructions are already documented in the GKE official docs. We should link to those docs are much as possible — so we're relying on TWs' work as much as possible. :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm open to bringing it back.)

@github-actions
Copy link

🚲 PR staged at http://104.155.170.199

@NimJay NimJay mentioned this pull request Sep 21, 2022
@github-actions
Copy link

🚲 PR staged at http://104.155.170.199

@@ -1,28 +1,39 @@
# NetworkPolicy + OnlineBoutique
# NetworkPolicy
Copy link
Collaborator Author

@NimJay NimJay Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed "+ OnlineBoutique" since I think it might be redundant (since we're already in the Online Boutique repo). I'm open to bringing it back.

@@ -22,3 +22,4 @@ components:
# - components/cymbal-branding
# - components/google-cloud-operations
# - components/memorystore
# - components/network-policy
Copy link
Collaborator Author

@NimJay NimJay Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal is to a add each and every Kustomize Component here:

  # - components/name-of-component

for convenience and so we could easily use sed to uncomment.

@github-actions
Copy link

🚲 PR staged at http://104.155.170.199

Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great stuffs!

@NimJay NimJay merged commit 99934c7 into main Sep 27, 2022
@NimJay NimJay deleted the nimjay-kustomize-network-policy branch September 27, 2022 14:21
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants