-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port NetworkPolicy
flavour to Kustomize
#1081
Conversation
As an example, here is the option you need to use when creating your cluster: | ||
```sh | ||
gcloud container clusters create \ | ||
--enable-dataplane-v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the step:
gcloud container clusters create \
--enable-dataplane-v2
because these GKE-specific instructions are already documented in the GKE official docs. We should link to those docs are much as possible — so we're relying on TWs' work as much as possible. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'm open to bringing it back.)
🚲 PR staged at http://104.155.170.199 |
🚲 PR staged at http://104.155.170.199 |
@@ -1,28 +1,39 @@ | |||
# NetworkPolicy + OnlineBoutique | |||
# NetworkPolicy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed "+ OnlineBoutique" since I think it might be redundant (since we're already in the Online Boutique repo). I'm open to bringing it back.
@@ -22,3 +22,4 @@ components: | |||
# - components/cymbal-branding | |||
# - components/google-cloud-operations | |||
# - components/memorystore | |||
# - components/network-policy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal is to a add each and every Kustomize Component here:
# - components/name-of-component
for convenience and so we could easily use sed
to uncomment.
🚲 PR staged at http://104.155.170.199 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great stuffs!
Background
Component
s for each flavour of Online Boutique — where possible.Change Summary
NetworkPolicy
resources to Kustomize.Testing Procedure
network-policy
Kustomize Component insidekustomize/kustomization.yaml
.NetworkPolicy
resources.You'll notice that the
NetworkPolicy
resources are included in the Kustomize build.Related PRs or Issues
NetworkPolicy
samples:NetworkPolicy
resources #778