Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adservice - openjdk:18-slim --> openjdk:18-alpine #1101

Merged
merged 1 commit into from
Sep 27, 2022
Merged

adservice - openjdk:18-slim --> openjdk:18-alpine #1101

merged 1 commit into from
Sep 27, 2022

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Sep 27, 2022 •
edited

adservice - openjdk:18-slim --> openjdk:18-alpine

  • Before: 275.1 MB --> 44 vulnerabilities
  • After: 248.8 MB --> 4 vulnerabilities

@mathieu-benoit mathieu-benoit requested a review from a team as a code owner September 27, 2022 11:31
@mathieu-benoit mathieu-benoit changed the title adservice - openjdk:18-alpine adservice - openjdk:18-slim --> openjdk:18-alpine Sep 27, 2022
@mathieu-benoit mathieu-benoit marked this pull request as draft September 27, 2022 11:33
@github-actions
Copy link

🚲 PR staged at http://35.222.142.4

@mathieu-benoit mathieu-benoit marked this pull request as ready for review September 27, 2022 11:41
@mathieu-benoit
Copy link
Contributor Author

Ready for your review, thanks!

NimJay
NimJay approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this time, I thought slim was smaller than alpine.
Interesting to learning that alpine is smaller than slim.

@NimJay
Copy link
Collaborator

NimJay commented Sep 27, 2022

All checks are passing. And the staging URL is working (I was able to check out my cart and switch currencies). Merging.

@NimJay NimJay merged commit 4fbe838 into main Sep 27, 2022
@NimJay NimJay deleted the mathieu-benoit/adservice-openjdk-18-alpine branch September 27, 2022 13:43
arbrown pushed a commit that referenced this pull request Sep 28, 2022
@mathieu-benoit @arbrown
openjdk:18-alpine (#1101)
bc811c4
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
@mathieu-benoit
openjdk:18-alpine (GoogleCloudPlatform#1101)
dd98607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NimJay NimJay NimJay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mathieu-benoit @NimJay