Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cymbal branding to error page #1186

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Add Cymbal branding to error page #1186

merged 2 commits into from
Oct 19, 2022

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Oct 19, 2022

Background

Fixes

#1166

Change Summary

  • Add the is_cymbal_brand/isCymbalBrand variable to the template that renders the error page.

Testing Procedure

  • If you would like to be thorough, you can
    1. skaffold dev this branch (nimjay/cymbal-error)
    2. Set the CYMBAL_BRANDING to "true" inside /kubernetes-manifests/frontend.yaml.
    3. kubectl delete deployment/cartservice to bring up the error page.
  • But I have done this testing myself and it worked! So feel free to skip testing during your review. :)

@github-actions
Copy link

🚲 PR staged at http://34.171.122.31

@NimJay NimJay marked this pull request as ready for review October 19, 2022 13:59
@NimJay NimJay requested a review from a team as a code owner October 19, 2022 13:59
@NimJay
Copy link
Collaborator Author

NimJay commented Oct 19, 2022

Update: I have tested this myself and it works!

See the "Cymbal" logo in the error page:

Screen Shot 2022-10-19 at 9 59 52 AM

@github-actions
Copy link

🚲 PR staged at http://34.171.122.31

Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bourgeoisor bourgeoisor merged commit 8214fcd into main Oct 19, 2022
@bourgeoisor bourgeoisor deleted the nimjay/cymbal-error branch October 19, 2022 17:05
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants