Add Cymbal branding to error page #1186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Fixes
#1166
Change Summary
is_cymbal_brand
/isCymbalBrand
variable to the template that renders the error page.Testing Procedure
skaffold dev
this branch (nimjay/cymbal-error
)CYMBAL_BRANDING
to"true"
inside/kubernetes-manifests/frontend.yaml
.kubectl delete deployment/cartservice
to bring up the error page.