-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loadgenerator
- Python 3.11
#1320
loadgenerator
- Python 3.11
#1320
Conversation
🚲 PR staged at http://35.223.27.27 |
Ready for your review, thanks! |
🚲 PR staged at http://35.223.27.27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
RUN apt-get -qq update \ | ||
&& apt-get install -y --no-install-recommends \ | ||
g++ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Praise: Thanks for noticing that we don't need this for loadgenerator
(because we're not using Cloud Profiler). And thanks for taking the initiative to delete it!
* loadgenerator - python 3.11 * Testing without g++
loadgenerator
- Python 3.11Note: Same number of CVEs, 47 + size of the container image increased with +2.1MB.
Because we have issue with Cloud Profiler preventing both
emailservice
andrecommendationservice
to be upgraded to Python 3.11 (#1318), proposing to at least go ahead withloadgenerator
for now.Also took the initiative to remove the unecessary/unused
g++
installation and dependencies update in thebuilder
stage.