Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadgenerator - Python 3.11 #1320

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Nov 29, 2022

loadgenerator - Python 3.11

Note: Same number of CVEs, 47 + size of the container image increased with +2.1MB.

Because we have issue with Cloud Profiler preventing both emailservice and recommendationservice to be upgraded to Python 3.11 (#1318), proposing to at least go ahead with loadgenerator for now.

Also took the initiative to remove the unecessary/unused g++ installation and dependencies update in the builder stage.

@mathieu-benoit mathieu-benoit requested a review from a team as a code owner November 29, 2022 19:37
@mathieu-benoit mathieu-benoit self-assigned this Nov 29, 2022
@github-actions
Copy link

🚲 PR staged at http://35.223.27.27

@mathieu-benoit
Copy link
Contributor Author

Ready for your review, thanks!

@mathieu-benoit mathieu-benoit marked this pull request as draft November 29, 2022 20:28
@github-actions
Copy link

🚲 PR staged at http://35.223.27.27

@mathieu-benoit mathieu-benoit marked this pull request as ready for review November 29, 2022 20:35
Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

RUN apt-get -qq update \
&& apt-get install -y --no-install-recommends \
g++

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: Thanks for noticing that we don't need this for loadgenerator (because we're not using Cloud Profiler). And thanks for taking the initiative to delete it!

@mathieu-benoit mathieu-benoit merged commit b26041a into main Nov 29, 2022
@mathieu-benoit mathieu-benoit deleted the mathieu-benoit/loadgenerator-python-3-11 branch November 29, 2022 21:23
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
* loadgenerator - python 3.11

* Testing without g++
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants