Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dee-platform-ops in CODEOWNERS #1423

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Use dee-platform-ops in CODEOWNERS #1423

merged 1 commit into from
Jan 9, 2023

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Dec 22, 2022 •
edited
Loading

Background

Change Summary

Additional Notes

Screenshot 2022-12-22 at 9 42 18 AM

Testing Procedure

  • After this is merged, make sure the aforementioned error no longer shows up in the CODEOWNERS file.

@github-actions
Copy link

🚲 PR staged at http://34.170.81.224

@xtineskim
Copy link
Contributor

good catch on this, LGTM! but wait for @askmeegs 's stamp as well 👍

@NimJay NimJay merged commit 83fc84c into main Jan 9, 2023
@NimJay NimJay deleted the nimjay-codeowners branch January 9, 2023 17:26
@NimJay
Copy link
Collaborator Author

NimJay commented Jan 9, 2023

"This CODEOWNERS file is valid." 👍

Screenshot 2023-01-09 at 12 27 13 PM

D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
@NimJay
Use dee-platform-ops in CODEOWNERS (GoogleCloudPlatform#1423)
51c498f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askmeegs askmeegs askmeegs approved these changes

@bourgeoisor bourgeoisor bourgeoisor approved these changes

@xtineskim xtineskim xtineskim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NimJay @xtineskim @askmeegs @bourgeoisor