Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Making changes to testing identity #1676

Merged
merged 11 commits into from Apr 20, 2023
Merged

Conversation

tpryan
Copy link
Collaborator

@tpryan tpryan commented Apr 7, 2023

Background

Before this PR tests were failing because of changes made to billing policy for internal Google projects

Change Summary

This change makes testing use a service account that has the ability to autogenerate a project with billing enabled in the clouddevrel joonix org.

@tpryan tpryan requested a review from a team as a code owner April 7, 2023 17:25
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

🚲 PR staged at http://35.239.104.194

@github-actions
Copy link

🚲 PR staged at http://35.239.104.194

@github-actions
Copy link

🚲 PR staged at http://35.239.104.194

@github-actions
Copy link

🚲 PR staged at http://35.239.104.194

@github-actions
Copy link

🚲 PR staged at http://35.239.104.194

@github-actions
Copy link

🚲 PR staged at http://35.239.104.194

@github-actions
Copy link

🚲 PR staged at http://35.239.104.194

@github-actions
Copy link

🚲 PR staged at http://35.239.104.194

@tpryan
Copy link
Collaborator Author

tpryan commented Apr 20, 2023

It keeps passing, so I'm going to skip yet another round of testing.

@tpryan tpryan enabled auto-merge (squash) April 20, 2023 18:27
@github-actions
Copy link

🚲 PR staged at http://35.239.104.194

@tpryan tpryan merged commit d0dfc54 into main Apr 20, 2023
4 checks passed
@tpryan tpryan deleted the deploystack-config-change branch April 20, 2023 18:30
mrcrgl pushed a commit to Even-on-Fridays/microservices-demo that referenced this pull request Sep 11, 2023
* fix: rename deprecated script names

* test: fixing deploystack testing in response to policy change for internal accounts

* test: correcting behavior around which identity is doing what

---------

Co-authored-by: Nim Jayawardena <nimjay@google.com>
Co-authored-by: minherz <minherz@users.noreply.github.com>
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
* fix: rename deprecated script names

* test: fixing deploystack testing in response to policy change for internal accounts

* test: correcting behavior around which identity is doing what

---------

Co-authored-by: Nim Jayawardena <nimjay@google.com>
Co-authored-by: minherz <minherz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants