New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Making changes to testing identity #1676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚲 PR staged at http://35.239.104.194 |
NimJay
approved these changes
Apr 10, 2023
🚲 PR staged at http://35.239.104.194 |
🚲 PR staged at http://35.239.104.194 |
🚲 PR staged at http://35.239.104.194 |
🚲 PR staged at http://35.239.104.194 |
🚲 PR staged at http://35.239.104.194 |
🚲 PR staged at http://35.239.104.194 |
🚲 PR staged at http://35.239.104.194 |
It keeps passing, so I'm going to skip yet another round of testing. |
🚲 PR staged at http://35.239.104.194 |
mrcrgl
pushed a commit
to Even-on-Fridays/microservices-demo
that referenced
this pull request
Sep 11, 2023
* fix: rename deprecated script names * test: fixing deploystack testing in response to policy change for internal accounts * test: correcting behavior around which identity is doing what --------- Co-authored-by: Nim Jayawardena <nimjay@google.com> Co-authored-by: minherz <minherz@users.noreply.github.com>
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
* fix: rename deprecated script names * test: fixing deploystack testing in response to policy change for internal accounts * test: correcting behavior around which identity is doing what --------- Co-authored-by: Nim Jayawardena <nimjay@google.com> Co-authored-by: minherz <minherz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Before this PR tests were failing because of changes made to billing policy for internal Google projects
Change Summary
This change makes testing use a service account that has the ability to autogenerate a project with billing enabled in the clouddevrel joonix org.