Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cartservice] Increases health check timeout #240

Merged
merged 4 commits into from Aug 19, 2019

Conversation

askmeegs
Copy link
Contributor

Closes #74

Problem: CartService restarts repeatedly due to failed liveness and readiness probes (the redis PING completes, but it takes > 1 second). Isolated the problem to the .NET StackExchange/Redis client library -- unclear if it's a timeout or connection pool issue.

Solution for now:

  1. Increase the timeout on both the liveness/readiness probes from 1 second to 5 seconds
  2. Re-use the existing cartservice redis client in the health check, rather than initialize a new client (this just adds more time)
  3. Upgrade the Redis .NET library to the latest version

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 18, 2019
@askmeegs askmeegs requested a review from ahmetb August 18, 2019 19:39
@askmeegs askmeegs merged commit 156dfce into GoogleCloudPlatform:master Aug 19, 2019
@askmeegs askmeegs deleted the cartservice-restart branch August 19, 2019 18:28
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
* Increases cartservice health check rpc timeout

* remove stopwatch from health check

* cleanup

* Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cartservice: unhealthy signals from grpc
3 participants