-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minikube instructions added #41
Minikube instructions added #41
Conversation
Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
I am ok with removing Docker-for-Desktop altogether! Let’s just talk about Minikube; adding more options just confuse people. |
Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
@ahmetb updated! |
Thanks Ihor! I have two questions:
|
@@ -91,7 +88,7 @@ Find **Protocol Buffers Descriptions** at the [`./pb` directory](./pb). | |||
|
|||
> 💡 Recommended for demos and making it available publicly. | |||
|
|||
1. Install tools specified in the previous section (Docker, kubectl, skaffold) | |||
1. Install tools specified in the previous section (kubectl, skaffold) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part of the diff is not accurate: Skaffold will still need a working docker build
locally even if it is deploying to a remote cluster.
I'm tempted to think: for now Docker for Desktop is doing a decent job here and we should probably keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahmetb It's fine with keeping DfD, the primary reason why I've added minikube - it's available for Linux.
I just did
and this brought the apiserver down or something like that, because
but kubectl worked fine before deploying the artifacts to minikube. :(
|
@ahmetb wow, thanks for testing. Will take a look and update the instructions respectively. |
@ahmetb it really doesn't work on minikube, and that's weird. Let's hold the PR now, I'll perform a deeper debugging and update the PR. |
I bumped the limits but no luck. If you have time, feel free to follow up on Minikube repo. I'm still open to this as long as (1) it works (2) localhost:80 or something like that is accessible. |
Hey guys,
Interested if it works for anyone else as well. |
Also had an issue with skaffold trying to push to docker hub so added this and it seemed to resolve: |
@dreamspider42 It works since minikube v1.0, I'll update the documentation when I'll have time. |
@dreamspider42 also, this is not necessary:
Instructions to run Minikube from this blog post are sufficient - https://kubernetes.io/blog/2019/03/28/running-kubernetes-locally-on-linux-with-minikube-now-with-kubernetes-1.14-support/. |
Yeah, its possible I screwed something up during the minikube install as I couldn't run minikube without sudo and then it wouldn't show me the dashboard. Thanks for the link though. I think the bigger thing is I wasnt sure where to hit the front-end URL via minikube (it wasn't available via localhost:80) without the commands in the other link. |
Fixes #40
Signed-off-by: Ihor Dvoretskyi ihor@linux.com