Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dotnet binary to start cartservice so its debuggable with vsdbg #571

Merged
merged 5 commits into from
Jul 14, 2021
Merged

Use dotnet binary to start cartservice so its debuggable with vsdbg #571

merged 5 commits into from
Jul 14, 2021

Conversation

j-windsor
Copy link
Contributor

Change summary:
Start using dotnet instead of standalone so it is easily debuggable with vsdbg.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 30, 2021
@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Jun 30, 2021 •
edited
Loading

Just curious here @j-windsor, should it be a dedicated Dockerfile.debug file for example with those changes and allow the debugging feature you are mentioning. This, in order to keep the current Dockerfile one light/small ready for Production/Release mode?

@j-windsor
Copy link
Contributor Author

@mathieu-benoit great idea! I adjusted accordingly.

kelsk
kelsk reviewed Jul 1, 2021
View reviewed changes
skaffold.yaml Outdated Show resolved Hide resolved
@bourgeoisor bourgeoisor changed the title use dotnet binary to start cartservice so its debuggable with vsdbg Use dotnet binary to start cartservice so its debuggable with vsdbg Jul 6, 2021
@askmeegs askmeegs self-requested a review July 13, 2021 21:44
askmeegs
askmeegs approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@askmeegs askmeegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with skaffold dev (default profile) and skaffold debug (debug profile). LGTM.

@askmeegs askmeegs merged commit d848308 into GoogleCloudPlatform:master Jul 14, 2021
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
@j-windsor
Cartservice debug profile + Dockerfile.debug (GoogleCloudPlatform#571)
1d4d651 
* suse dotnet binary to start cartservice so its debugable

* use dockerfile.debug

* readd newline

* update skaffold.yaml copyright

* kelsey PR changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askmeegs askmeegs askmeegs approved these changes

@kelsk kelsk kelsk approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@j-windsor @mathieu-benoit @askmeegs @kelsk