node 12 -> node 16, grpc -> grpc-js #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
🚲 PR staged at http://34.73.14.146 |
Shabirmean
reviewed
Nov 23, 2021
Shabirmean
suggested changes
Nov 23, 2021
|
🚲 PR staged at http://34.73.14.146 |
Shabirmean
reviewed
Nov 25, 2021
|
I have updated the PR with some minor improvements. The diff between the last commit from the author and all my commits can be viewed at this link: |
NimJay
approved these changes
Nov 25, 2021
There was a problem hiding this comment.
I have tried skaffold dev and did a quick manual test of my deployment (on my GKE cluster).
The changes also look good, and yes, Node.js 16 is the way to go today.
Approved!
Thanks, @Shabirmean, for taking over this pull-request and tidying it up. 🙏
Shabirmean
requested review from
Shabirmean
and removed request for
Shabirmean
Shabirmean
approved these changes
Nov 25, 2021
fty4
added a commit
to fty4/gcp-microservices-demo
that referenced
this pull request
Dec 14, 2021
This reverts commit 3f437db. linked to issue 647
fty4
added a commit
to fty4/gcp-microservices-demo
that referenced
this pull request
Dec 15, 2021
This reverts commit 3f437db. linked to issue 647
sitaramkm
pushed a commit
to sitaramkm/microservices-demo
that referenced
this pull request
Mar 27, 2022
* save work so far * upgrade paymentservice * cleanup * Currency package lock * payment packagelog * cleanup: fix indent and minor changes * chore: test commit * chore: revert the test commit * cleanup: update the cloud profiler version Co-authored-by: shabirmean <7249208+Shabirmean@users.noreply.github.com> Co-authored-by: shabirmean <shabirmean@google.com>
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
* save work so far * upgrade paymentservice * cleanup * Currency package lock * payment packagelog * cleanup: fix indent and minor changes * chore: test commit * chore: revert the test commit * cleanup: update the cloud profiler version Co-authored-by: shabirmean <7249208+Shabirmean@users.noreply.github.com> Co-authored-by: shabirmean <shabirmean@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across these upgrades while trying to fix #538 - our Node and grpc JS versions were out of date and/or deprecated. This turned out to not be the cause of the memory leak but we should probably still upgrade.
changelog
grpctogrpc-js.grpcis deprecated. See Migrating to grpc-js for thebind-asyncchange you see in this PR.