Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: update the dotnet version in the master branch ci workflow #633

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

Shabirmean
Copy link
Member

Fixes .

Issue

Change summary:

  • Update the master branch GH actions workflow file to use the latest .NET SDK

Related issues/PRs:

@Shabirmean Shabirmean requested a review from a team as a code owner November 23, 2021 19:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 23, 2021
@github-actions
Copy link

🚲 PR staged at http://34.75.58.116

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the timely fix, @Shabirmean!
This looks good — approved.

Do we need to now install dotnet-sdk-6.0 on our VMs (Action Runners), given that the install-dependencies.sh file has been updated?

@Shabirmean
Copy link
Member Author

Thanks for the timely fix, @Shabirmean! This looks good — approved.

Do we need to now install dotnet-sdk-6.0 on our VMs (Action Runners), given that the install-dependencies.sh file has been updated?

Thank you for the quick review @NimJay
I have already run the updated line on the GH Actions VMs!

@Shabirmean Shabirmean merged commit 9f330fe into master Nov 23, 2021
@Shabirmean Shabirmean deleted the dotnet-master-ci branch November 23, 2021 20:16
sitaramkm pushed a commit to sitaramkm/microservices-demo that referenced this pull request Mar 27, 2022
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants