Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log4j 2nd update #661

Merged
merged 1 commit into from
Dec 14, 2021
Merged

log4j 2nd update #661

merged 1 commit into from
Dec 14, 2021

Conversation

mandarjog
Copy link
Contributor

@mandarjog mandarjog commented Dec 14, 2021

Fix missed in the previous update.

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-45046

Not included in v0.3.3

@mandarjog mandarjog requested a review from a team as a code owner December 14, 2021 19:10
@NimJay
Copy link
Collaborator

NimJay commented Dec 14, 2021

Thanks for creating this PR, @mandarjog!
That was fast! ⚡

We will work on reviewing this immediately.
But we will not be creating a new release of microservices-demo immediately.
Reason:

  • According to the link you shared, "Log4j 2.15.0 was incomplete in certain non-default configurations".
  • But we're using default Log4j configurations for this app.

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deployment-tests (local-code) job is currently failing because our GitHub Action runners are not able to create publicly accessible GKE Ingresses. We're working on fixing this.
In the meantime, I've tested deployment of changes from this pull-request in my own GKE cluster.
I did a quick smoke test. Everything works. :)
Approved!

Thanks again, @mandarjog! 👏

@NimJay NimJay merged commit 5e86b86 into GoogleCloudPlatform:master Dec 14, 2021
sitaramkm pushed a commit to sitaramkm/microservices-demo that referenced this pull request Mar 27, 2022
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants