Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed ci workflows, md to reference main as default #686

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

xtineskim
Copy link
Contributor

@xtineskim xtineskim commented Jan 12, 2022

Background

To promote inclusive language, and to follow Github’s ongoing efforts to remove instances of the word “master,” Anthos/GKE DPE proposes to move the base branch in our Github sample repos from “master” to “main,” and by default use the branch “main” for all new repos going forward.

Fixes

n/a

Change Summary

Rename master to main in our workflows we have in .github.
Renamed any references to master in our md files

Additional Notes

After this PR is merged, then we will change the default branch to main (scheduled time for tomorrow to do this).
Since Github redirects from master to main with URLs, there will be no breaking changes in redirect links (but I will change them and cc you all!)

Testing Procedure

Ensure that I made the correct and necessary changes!

Related PRs or Issues

n/a

@xtineskim xtineskim requested a review from NimJay January 12, 2022 21:59
@xtineskim xtineskim requested a review from a team as a code owner January 12, 2022 21:59
Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect! Thank you, @ckim328! 👏

Approved.
I'll let you do the merging — in case you want to time it a certain way.

@@ -3,7 +3,7 @@
</p>


![Continuous Integration](https://github.com/GoogleCloudPlatform/microservices-demo/workflows/Continuous%20Integration%20-%20Master/Release/badge.svg)
![Continuous Integration](https://github.com/GoogleCloudPlatform/microservices-demo/workflows/Continuous%20Integration%20-%20Main/Release/badge.svg)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: I should probably test this SVG file's existence once the branch has been renamed.

@xtineskim xtineskim merged commit e1c04f8 into master Jan 13, 2022
@xtineskim xtineskim deleted the default-main-rename branch January 13, 2022 17:46
sitaramkm pushed a commit to sitaramkm/microservices-demo that referenced this pull request Mar 27, 2022
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants