Shipping fee to be a flat rate #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtineskim
changed the title
|
🚲 PR staged at http://104.154.56.155 |
bourgeoisor
reviewed
Jan 20, 2022
NimJay
approved these changes
Jan 20, 2022
This was referenced Jan 20, 2022
sitaramkm
pushed a commit
to sitaramkm/microservices-demo
that referenced
this pull request
Mar 27, 2022
* quoteByCoutnFloat returns flat rate * Fix to the test quote
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
* quoteByCoutnFloat returns flat rate * Fix to the test quote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Related to #691 , where it was found that the shipping cost was calculated using
As per the suggestion in the issue, I changed the shipping fee to be a 'flat rate'
Fixes
Related to this issue #691
Change Summary
Changed
quoteByCountFloatin the shippingService to return8.99(an arbitrary number, but shipping usually costs around this much in my experience)Additional Notes
If we did want to calculate the shipping rate still, I'm ok with closing this PR!
Testing Procedure
Tested it locally, and shows the shipping rate to be
8.99