Complete PR#689 - Cloud Armor stup for onlineboutique.dev #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o explicitly set it
|
🚲 PR staged at http://34.132.134.138 |
4 tasks
NimJay
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Previous thread: #689 (comment)
I just checked kubectl get service frontend-nodeport and got:
Error from server (NotFound): services "frontend-nodeport" not found
which is what I expect. No more frontend-nodeport. :)
I also see that the Cloud Armor policy has a target.
Thanks again for taking care of this, @mathieu-benoit.
Approved.
sitaramkm
pushed a commit
to sitaramkm/microservices-demo
that referenced
this pull request
Mar 27, 2022
…o explicitly set it (GoogleCloudPlatform#698)
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
…o explicitly set it (GoogleCloudPlatform#698)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultBackendfield of the Ingress to avoid any old pointer to the oldfrontend-nodeportservice