Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: rsa pin #714

Merged
merged 5 commits into from
Feb 9, 2022
Merged

cleanup: rsa pin #714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
01ac379
Bumping cloud-profiler
Feb 8, 2022
20db4fc
Bumping api-core
Feb 8, 2022
2db10cb
Pinned rsa to 4.7
Feb 8, 2022
824d61a
Updated opencensus lib
Feb 8, 2022
4b54494
merged in main
Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/recommendationservice/requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
google-api-core==1.23.0
google-python-cloud-debugger==2.18
google-cloud-profiler==3.0.7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why do we manually upgrade google-cloud-profiler as well? Is it because the older version of google-cloud-profiler doesn't work with rsa==4.7?

Copy link
Contributor Author

@xtineskim xtineskim Feb 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will eventually have to bump google-cloud-profiler so that it's compatible with v2.x of google-api-core
While this isn't completely necessary right now, we will have to bump it in the future
(also google-cloud-profiler v1.1.2 is 2 years old 😅 )

I tested and looked at the documentation for how we use google-cloud-profiler, no changes to the code is needed for how we use this module

grpcio-health-checking==1.33.2
grpcio==1.33.2
opencensus==0.7.11
opencensus==0.8.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why do we manually upgrade opencensus as well? Is it because the older version of opencensus doesn't work with rsa==4.7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bumpedopencensus since I saw it was an older lib
I thought it would be best if we update these while we can (instead of letting them age), but I can bump this back down to 0.7.11!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Nope, don't bump it back down.
I just thought it was related to the rsa stuff and was confused.
But yes, thanks for updating opencensus as well! 👍

opencensus-ext-stackdriver==0.7.3
opencensus-ext-grpc==0.7.1
python-json-logger==0.1.11
google-cloud-profiler==1.1.2
requests==2.27.1
urllib3==1.26.5
rsa==4.7
pyyaml==6.0
10 changes: 6 additions & 4 deletions src/recommendationservice/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ google-cloud-core==1.5.0
# via google-cloud-trace
google-cloud-monitoring==0.36.0
# via opencensus-ext-stackdriver
google-cloud-profiler==1.1.2
google-cloud-profiler==3.0.7
# via -r requirements.in
google-cloud-trace==0.24.0
# via opencensus-ext-stackdriver
Expand All @@ -61,7 +61,7 @@ httplib2==0.19.0
# google-auth-httplib2
idna==2.10
# via requests
opencensus==0.7.11
opencensus==0.8.0
# via
# -r requirements.in
# opencensus-ext-grpc
Expand Down Expand Up @@ -99,8 +99,10 @@ requests==2.27.1
# -r requirements.in
# google-api-core
# google-cloud-profiler
rsa==4.6
# via google-auth
rsa==4.7
# via
# -r requirements.in
# google-auth
six==1.15.0
# via
# google-api-core
Expand Down