Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed checkout in cleanup workflow #718

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Conversation

xtineskim
Copy link
Contributor

Background

Similar to this issue that we saw happening in Bank of Anthos (GoogleCloudPlatform/bank-of-anthos#619)

Fixes

If a branch was manually deleted, then the cleanup workflow would not work in successfully deleting the staged PR cluster

Change Summary

Removed the git checkout step from the cleanup workflow

Additional Notes

n/a

Testing Procedure

Related PRs or Issues

n/a

@xtineskim xtineskim requested review from bourgeoisor and a team February 11, 2022 20:45
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

🚲 PR staged at http://104.197.91.71

@xtineskim xtineskim merged commit b8fe890 into main Feb 11, 2022
@xtineskim xtineskim deleted the issue-fix-cleanup-race branch February 11, 2022 21:17
@xtineskim
Copy link
Contributor Author

passed: https://github.com/GoogleCloudPlatform/microservices-demo/actions/runs/1831561468

sitaramkm pushed a commit to sitaramkm/microservices-demo that referenced this pull request Mar 27, 2022
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants