Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDistributedCache implementation and refactoring for cartservice #838

Merged
merged 12 commits into from
May 28, 2022
Merged

IDistributedCache implementation and refactoring for cartservice #838

merged 12 commits into from
May 28, 2022

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented May 25, 2022 •
edited
Loading

IDistributedCache implementation and refactoring for cartservice for its interaction with the redis database.

Fixes:

Tests conducted:

  • Unit tests
  • PR staged in http://35.232.241.213/
  • Test in memory
  • Test with redis container
  • Distributed redis with multiple clusters
  • Test with Memorystore (redis)
  • Test in Memorystore (redis) + TLS

Example of what this allows: https://medium.com/p/64b71969318d

Other updates:

  • Grpc.Net.Client 2.46.0
  • Grpc.AspNetCore 2.46.0
  • Grpc.HealthCheck 2.46.3

@mathieu-benoit mathieu-benoit requested a review from a team as a code owner May 25, 2022 02:20
@mathieu-benoit mathieu-benoit marked this pull request as draft May 25, 2022 02:20
@github-actions
Copy link

🚲 PR staged at http://35.232.241.213

@github-actions
Copy link

🚲 PR staged at http://35.232.241.213

@github-actions
Copy link

🚲 PR staged at http://35.232.241.213

@github-actions
Copy link

🚲 PR staged at http://35.232.241.213

@mathieu-benoit mathieu-benoit mentioned this pull request May 25, 2022
Closed
@mathieu-benoit mathieu-benoit marked this pull request as ready for review May 27, 2022 12:00
@mathieu-benoit mathieu-benoit added lang: dotnet Issues specific to .NET. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 27, 2022
xtineskim
xtineskim approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@xtineskim xtineskim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the explanations too Mathieu!
I just want @NimJay to go through these changes as well, since he's the lead for this

@github-actions
Copy link

🚲 PR staged at http://35.232.241.213

NimJay
NimJay approved these changes May 27, 2022
View reviewed changes
Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @mathieu-benoit!
This is excellent!

@mathieu-benoit mathieu-benoit merged commit 65b5522 into main May 28, 2022
@mathieu-benoit mathieu-benoit deleted the mathieu-benoit/fix-cartservice branch May 28, 2022 01:03
This was referenced May 28, 2022
Closed
Closed
@okostine okostine mentioned this pull request Jul 6, 2023
Open
This was referenced Jul 6, 2023
Open
Open
@xmyqyl4x xmyqyl4x mentioned this pull request Jul 7, 2023
Open
@okostine okostine mentioned this pull request Jul 7, 2023
Open
@drashinkar drashinkar mentioned this pull request Jul 8, 2023
Open
@nr-security-github nr-security-github mentioned this pull request Jul 11, 2023
Open
This was referenced Jul 11, 2023
Open
Open
@okostine okostine mentioned this pull request Jul 11, 2023
Open
@xmyqyl4x xmyqyl4x mentioned this pull request Jul 11, 2023
Open
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
@mathieu-benoit @xtineskim
IDistributedCache implementation and refactoring for cartservice (G…
5458013 
…oogleCloudPlatform#838)

* better implementation for cartservice

* Microsoft.Extensions.Caching.StackExchangeRedis

* cleanup

* Grpc.Net.Client 2.46.0

* Grpc.AspNetCore 2.46.0

* Grpc.HealthCheck 2.46.3

* cleanup

* value.IsNull

* value == null

Co-authored-by: Christine Kim <35876108+ckim328@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NimJay NimJay NimJay approved these changes

@xtineskim xtineskim xtineskim approved these changes

Assignees
No one assigned
Labels
lang: dotnet Issues specific to .NET. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mathieu-benoit @NimJay @xtineskim