Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent gh actions running on draft PRs #926

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Prevent gh actions running on draft PRs #926

merged 2 commits into from
Jul 19, 2022

Conversation

xtineskim
Copy link
Contributor

Background

On draft PRs, the gh ci runs. Depending on how long a draft is open for, it could use up resources for us.

Fixes

n/a

Change Summary

Add a type on ready to review, and requested review in the ci-pr.yaml

Additional Notes

n/a

Testing Procedure

Putting this PR in draft, and seeing if gh actions runs

Related PRs or Issues

n/a

@xtineskim xtineskim marked this pull request as ready for review July 19, 2022 14:03
@xtineskim xtineskim requested a review from a team as a code owner July 19, 2022 14:03
@github-actions
Copy link

🚲 PR staged at http://34.72.135.108

1 similar comment
@github-actions
Copy link

🚲 PR staged at http://34.72.135.108

Copy link
Member

@Shabirmean Shabirmean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you for this improvement!

@@ -15,8 +15,10 @@
name: "Continuous Integration - Pull Request"
on:
pull_request:
types: [review_requested, ready_for_review]
Copy link
Collaborator

@NimJay NimJay Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Could you please share the link to the relevant GitHub documentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NimJay NimJay merged commit cec3f37 into main Jul 19, 2022
@NimJay NimJay deleted the ci-fix-pr-draft branch July 19, 2022 14:14
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants