-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent gh actions running on draft PRs #926
Conversation
🚲 PR staged at http://34.72.135.108 |
1 similar comment
🚲 PR staged at http://34.72.135.108 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for this improvement!
@@ -15,8 +15,10 @@ | |||
name: "Continuous Integration - Pull Request" | |||
on: | |||
pull_request: | |||
types: [review_requested, ready_for_review] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Could you please share the link to the relevant GitHub documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Background
On draft PRs, the gh ci runs. Depending on how long a draft is open for, it could use up resources for us.
Fixes
n/a
Change Summary
Add a type on
ready to review
, andrequested review
in theci-pr.yaml
Additional Notes
n/a
Testing Procedure
Putting this PR in draft, and seeing if gh actions runs
Related PRs or Issues
n/a