Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cartservice - dotnet 6.0.8 #948

Merged
merged 7 commits into from
Aug 10, 2022
Merged

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Aug 10, 2022

@mathieu-benoit mathieu-benoit requested a review from a team as a code owner August 10, 2022 12:32
@mathieu-benoit mathieu-benoit marked this pull request as draft August 10, 2022 12:32
@mathieu-benoit mathieu-benoit marked this pull request as ready for review August 10, 2022 12:43
@github-actions
Copy link

🚲 PR staged at http://34.133.102.101

2 similar comments
@github-actions
Copy link

🚲 PR staged at http://34.133.102.101

@github-actions
Copy link

🚲 PR staged at http://34.133.102.101

@mathieu-benoit
Copy link
Contributor Author

Ready for your review, thanks!

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mathieu-benoit!
This looks good.
I've tested the staging URL. The cart works.
Plus, all checks are passing.

@NimJay NimJay merged commit 4e1a399 into main Aug 10, 2022
@NimJay NimJay deleted the mathieu-benoit/cartservice-dotnet-6-0-8 branch August 10, 2022 18:23
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
* dotnet/sdk:6.0.400 + dotnet/runtime-deps:6.0.8-alpine3.16-amd64

* Grpc.AspNetCore 2.47.0

* Grpc.HealthCheck 2.47.0

* Grpc.Net.Client 2.47.0

* Microsoft.AspNetCore.TestHost 6.0.8

* Microsoft.NET.Test.Sdk 17.3.0

* xunit 2.4.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants