install-cni.sh tweaks for performance #324
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingyuanliang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @aojea |
jingyuanliang
force-pushed
the
nice2
branch
2 times, most recently
from
6156ec3
to
8598618
Compare
| ipv6_subnet_configured="true" | ||
| SUBNETS_REPLACEMENT+=("$(jq -nc --arg subnet "${subnet}" '[{"subnet": $subnet}]')") | ||
| ROUTES_REPLACEMENT+=('{"dst": "::/0"}') | ||
| else | ||
| echo "[ERROR] Subnet detected in .spec.podCIDRs '${subnet}' is not a valid IP range" | ||
| log "[ERROR] Subnet detected in .spec.podCIDRs '${subnet}' is not a valid IP range" |
There was a problem hiding this comment.
Maybe it's better to introduce log level on the log handler method instead. I.e. separate methods for log_debug, log_info and log_error. Also log_error might have built-in script termination with error code.
There was a problem hiding this comment.
The current logs are pretty random... I just replaced all echo with log for the purpose of appending timestamps. Maybe more improvements later if we have capacity.
There was a problem hiding this comment.
Sounds good! It's definitely an improvement even in current state.
|
/assign @sypakine |
|
/lgtm |
google-oss-prow
bot
merged commit 3f369c7
into
GoogleCloudPlatform:master
nicecommand allowing setting lower nice valuescatusage and avoidjq -csolely for log prettiness/assign @marqc