Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

ADD step copies local node_modules to the container #22

Closed
Guuz opened this issue Oct 14, 2014 · 2 comments
Closed

ADD step copies local node_modules to the container #22

Guuz opened this issue Oct 14, 2014 · 2 comments

Comments

@Guuz
Copy link

Guuz commented Oct 14, 2014

Hello,

On line 6 of the dockerfile (https://github.com/GoogleCloudPlatform/nodejs-docker/blob/master/runtime/Dockerfile#L6) the local app files are added to the container. In the steps before the right node_module folder has been created.
But the step on line 6 will copy your (dirty) local node_modules over the (clean) container node_modules.
This is very bad for so many reasons! ;-)

ps. i'm using managed vm's with custom runtimes; a .dockerignore file does not work.
ps2. I accidentally also posted this issue at the docker repository github page. But this is actually relevant for both. See dockerfile/nodejs-runtime#2

@proppy
Copy link
Member

proppy commented Oct 15, 2014

@Guuz you might want to report the same issue here: https://github.com/docker-library/node/

@JustinBeckwith
Copy link
Contributor

I believe this is addressed. Feel free to re-open if this is still an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants