You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 28, 2024. It is now read-only.
On line 6 of the dockerfile (https://github.com/GoogleCloudPlatform/nodejs-docker/blob/master/runtime/Dockerfile#L6) the local app files are added to the container. In the steps before the right node_module folder has been created.
But the step on line 6 will copy your (dirty) local node_modules over the (clean) container node_modules.
This is very bad for so many reasons! ;-)
ps. i'm using managed vm's with custom runtimes; a .dockerignore file does not work.
ps2. I accidentally also posted this issue at the docker repository github page. But this is actually relevant for both. See dockerfile/nodejs-runtime#2
The text was updated successfully, but these errors were encountered:
Hello,
On line 6 of the dockerfile (https://github.com/GoogleCloudPlatform/nodejs-docker/blob/master/runtime/Dockerfile#L6) the local app files are added to the container. In the steps before the right
node_module
folder has been created.But the step on line 6 will copy your (dirty) local
node_modules
over the (clean) containernode_modules
.This is very bad for so many reasons! ;-)
ps. i'm using managed vm's with custom runtimes; a
.dockerignore
file does not work.ps2. I accidentally also posted this issue at the docker repository github page. But this is actually relevant for both. See dockerfile/nodejs-runtime#2
The text was updated successfully, but these errors were encountered: