Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD step copies local node_modules to the container #2

Open
Guuz opened this issue Oct 14, 2014 · 0 comments
Open

ADD step copies local node_modules to the container #2

Guuz opened this issue Oct 14, 2014 · 0 comments

Comments

@Guuz
Copy link

Guuz commented Oct 14, 2014

Hello,

On line 13 of the dockerfile (https://github.com/dockerfile/nodejs-runtime/blob/master/Dockerfile#L13) the local app files are added to the container. In the steps before the right node_module folder has been created.
But the step on line 13 will copy your (dirty) local node_modules over the (clean) container node_modules.
This is very bad for so many reasons! ;-)

ps. i'm using managed vm's with custom runtimes; a .dockerignore file does not work.

edit: I just noticed this is not the Google managed repo of the docker image. But this is probably still relevant. See GoogleCloudPlatform/nodejs-docker#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant